Issue 107663012: Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around!

Issue 107663012: Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around! (Closed)

Created:
7 years ago by djsollen

Modified:
7 years ago

Reviewers:
bungeman-skia, scroggo, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around! Committed: http://code.google.com/p/skia/source/detail?r=12756

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -56 lines)			Patch
	M	include/ports/SkTypeface_android.h	View		2 chunks	+1 line, -5 lines	2 comments	Download
	M	src/ports/SkFontConfigInterface_android.cpp	View		4 chunks	+32 lines, -51 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

reed1

public include lgtm, deferring to others for actual reviewing https://codereview.chromium.org/107663012/diff/1/include/ports/SkTypeface_android.h File include/ports/SkTypeface_android.h (right): https://codereview.chromium.org/107663012/diff/1/include/ports/SkTypeface_android.h#newcode93 include/ports/SkTypeface_android.h:93: ...

7 years ago (2013-12-18 19:11:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/107663012/1

7 years ago (2013-12-18 19:13:27 UTC) #4

djsollen

https://codereview.chromium.org/107663012/diff/1/include/ports/SkTypeface_android.h File include/ports/SkTypeface_android.h (right): https://codereview.chromium.org/107663012/diff/1/include/ports/SkTypeface_android.h#newcode93 include/ports/SkTypeface_android.h:93: #include "../harfbuzz_ng/src/hb.h" On 2013/12/18 19:11:36, reed1 wrote: > man ...

7 years ago (2013-12-18 19:14:01 UTC) #5

Message was sent while issue was closed.

Change committed as 12756

Expand Messages | Collapse Messages