chrome/chrome_exe.gypi - Issue 107663008: Chrome browser process DLL blacklist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_exe.gypi

Issue 107663008: Chrome browser process DLL blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Greg's feedback. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_exe.gypi

diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi

index abd63a3c7d6663d050ccd4e083e4ad596112c722..c8f9ceff6911c124e5675586d3dd8b0b305b7b3a 100644

--- a/chrome/chrome_exe.gypi

+++ b/chrome/chrome_exe.gypi

@@ -465,6 +465,8 @@

}],

['OS=="win"', {

'dependencies': [

+ # Note that chrome_elf must be listed first. Do not reorder it.

+ '../chrome_elf/chrome_elf.gyp:chrome_elf',

Sigurður Ásgeirsson 2013/12/17 14:31:01 The DLL dependency list and order here could do wi

robertshield 2013/12/17 14:34:10 Agreed! Tests for this and the other are in a foll

'chrome_dll',

'chrome_nacl_win64',

'chrome_process_finder',

@@ -474,7 +476,6 @@

'../base/base.gyp:base',

'../breakpad/breakpad.gyp:breakpad_handler',

'../breakpad/breakpad.gyp:breakpad_sender',

- '../chrome_elf/chrome_elf.gyp:chrome_elf',

'../components/components.gyp:breakpad_component',

'../components/components.gyp:policy',

'../sandbox/sandbox.gyp:sandbox',