Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: chrome_elf/chrome_elf.gyp

Issue 107663008: Chrome browser process DLL blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Greg's feedback. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 }, 7 },
8 'includes': [ 8 'includes': [
9 '../build/win_precompile.gypi', 9 '../build/win_precompile.gypi',
10 '../chrome/version.gypi', 10 '../chrome/version.gypi',
11 'blacklist.gypi',
11 ], 12 ],
12 'targets': [ 13 'targets': [
13 { 14 {
14 'target_name': 'chrome_elf', 15 'target_name': 'chrome_elf',
15 'type': 'shared_library', 16 'type': 'shared_library',
16 'include_dirs': [ 17 'include_dirs': [
17 '..', 18 '..',
18 ], 19 ],
19 'sources': [ 20 'sources': [
20 'chrome_elf.def', 21 'chrome_elf.def',
21 'chrome_elf_main.cc', 22 'chrome_elf_main.cc',
22 'chrome_elf_main.h', 23 'chrome_elf_main.h',
23 ], 24 ],
24 'dependencies': [ 25 'dependencies': [
26 'blacklist',
25 'chrome_elf_lib', 27 'chrome_elf_lib',
26 ], 28 ],
27 'msvs_settings': { 29 'msvs_settings': {
28 'VCLinkerTool': { 30 'VCLinkerTool': {
29 'BaseAddress': '0x01c20000', 31 'BaseAddress': '0x01c20000',
30 # Set /SUBSYSTEM:WINDOWS for chrome_elf.dll (for consistency). 32 # Set /SUBSYSTEM:WINDOWS for chrome_elf.dll (for consistency).
31 'SubSystem': '2', 33 'SubSystem': '2',
34 # Exclude explicitly unwanted libraries from the link line.
35 'IgnoreAllDefaultLibraries': 'true',
Sigurður Ásgeirsson 2013/12/17 14:31:01 I'd suggest adding a unittest to verify the user32
robertshield 2013/12/17 14:34:10 Agreed! Tests for this and the other are in a foll
36 'AdditionalDependencies!': [
37 'user32.lib',
38 ],
39 'IgnoreDefaultLibraryNames': [
40 'user32.lib',
41 ],
32 }, 42 },
33 }, 43 },
34 }, 44 },
35 { 45 {
36 'target_name': 'chrome_elf_unittests', 46 'target_name': 'chrome_elf_unittests',
37 'type': 'executable', 47 'type': 'executable',
38 'sources': [ 48 'sources': [
49 'blacklist/test/blacklist_test.cc',
39 'ntdll_cache_unittest.cc', 50 'ntdll_cache_unittest.cc',
40 ], 51 ],
41 'include_dirs': [ 52 'include_dirs': [
42 '..', 53 '..',
43 ], 54 ],
44 'dependencies': [ 55 'dependencies': [
45 'chrome_elf_lib', 56 'chrome_elf_lib',
46 '<(DEPTH)/base/base.gyp:run_all_unittests', 57 '../base/base.gyp:base',
47 '<(DEPTH)/testing/gtest.gyp:gtest', 58 '../base/base.gyp:run_all_unittests',
59 '../base/base.gyp:test_support_base',
60 '../sandbox/sandbox.gyp:sandbox',
61 '../testing/gtest.gyp:gtest',
62 'blacklist',
63 'blacklist_test_dll_1',
64 'blacklist_test_dll_2',
65 'blacklist_test_dll_3',
66 'blacklist_test_main_dll',
48 ], 67 ],
49 }, 68 },
50 { 69 {
51 'target_name': 'chrome_elf_lib', 70 'target_name': 'chrome_elf_lib',
52 'type': 'static_library', 71 'type': 'static_library',
53 'include_dirs': [ 72 'include_dirs': [
54 '..', 73 '..',
55 ], 74 ],
56 'sources': [ 75 'sources': [
57 'chrome_elf_types.h', 76 'chrome_elf_types.h',
58 'ntdll_cache.cc', 77 'ntdll_cache.cc',
59 'ntdll_cache.h', 78 'ntdll_cache.h',
60 ], 79 ],
61 }, 80 },
62 ], 81 ],
63 } 82 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698