chrome_elf/blacklist.gypi - Issue 107663008: Chrome browser process DLL blacklist.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome_elf/blacklist.gypi

Issue 107663008: Chrome browser process DLL blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge unit tests into chrome_elf_unittests.exe. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'targets': [

	6 {

	7 'target_name': 'blacklist',

	8 'type': 'static_library',

	9 'sources': [

	10 'blacklist/blacklist.cc',

	11 'blacklist/blacklist.h',

	12 'blacklist/blacklist_interceptions.cc',
	grt (UTC plus 2) 2013/12/16 23:33:49 this appears to depend on stuff in base. please ad this appears to depend on stuff in base. please add an explicit dependency on base to this target. robertshield 2013/12/17 03:43:04 This was explicitly not done to ensure no dependen Show quoted text On 2013/12/16 23:33:49, grt wrote: > this appears to depend on stuff in base. please add an explicit dependency on > base to this target. This was explicitly not done to ensure no dependencies on base that would involve pulling in compilation units that themselves pull in undesirable dependencies. The three things being depended on are: 1) basictypes.h 2) string16.h 3) pe_image.h/pe_image.cc 1 and 2 are only header files on windows, 3 is defined in base_static which is now depended on. If 1) or 2) are ever refactored in such a way that this changes, chrome_elf should break. Added comments here and in the .cc file to this effect.
	13 'blacklist/blacklist_interceptions.h',

	14 ],

	15 'dependencies': [

	16 '../sandbox/sandbox.gyp:sandbox',

	17 ],

	18 },

	19 {

	20 'target_name': 'blacklist_test_main_dll',

	21 'type': 'shared_library',

	22 'sources': [

	23 'blacklist/test/blacklist_test_main_dll.cc',

	24 'blacklist/test/blacklist_test_main_dll.def',

	25 ],

	26 'dependencies': [

	27 '../base/base.gyp:base',

	28 'blacklist',

	29 ],

	30 },

	31 {

	32 'target_name': 'blacklist_test_dll_1',

	33 'type': 'shared_library',
	grt (UTC plus 2) 2013/12/16 23:33:49 it looks like this dll and the next are only loade it looks like this dll and the next are only loaded dynamically. should they not be loadable_module targets like the third? robertshield 2013/12/17 03:43:04 Done. Show quoted text On 2013/12/16 23:33:49, grt wrote: > it looks like this dll and the next are only loaded dynamically. should they not > be loadable_module targets like the third? Done.
	34 'sources': [

	35 'blacklist/test/blacklist_test_dll_1.cc',

	36 'blacklist/test/blacklist_test_dll_1.def',

	37 ],

	38 },

	39 {

	40 'target_name': 'blacklist_test_dll_2',

	41 'type': 'shared_library',

	42 'sources': [

	43 'blacklist/test/blacklist_test_dll_2.cc',

	44 'blacklist/test/blacklist_test_dll_2.def',

	45 ],

	46 },

	47 {

	48 'target_name': 'blacklist_test_dll_3',

	49 'type': 'loadable_module',

	50 'sources': [

	51 'blacklist/test/blacklist_test_dll_3.cc',

	52 ],

	53 },

	54 ],

	55 }

	56

OLD	NEW

« no previous file with comments | « chrome_elf/DEPS ('k') | chrome_elf/blacklist/blacklist.h » ('j') | chrome_elf/blacklist/test/blacklist_test.cc » ('J')