Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1076623004: Add temporary CHECKs in ICU init to attempt to more closely locate crash (Closed)

Created:
5 years, 8 months ago by scottmg
Modified:
5 years, 8 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add temporary CHECKs in ICU init to attempt to more closely locate crash At the moment it CHECKs on false return from base::i18n::InitalizeICU. Try to locate it to a particular failure in that function to have a better idea what's failing. R=jshin@chromium.org BUG=445616 Committed: https://crrev.com/7a33682428a1fb621da6f540ae1fce1cb2200d12 Cr-Commit-Position: refs/heads/master@{#326946}

Patch Set 1 #

Patch Set 2 : save path #

Patch Set 3 : #if win the checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M base/i18n/icu_util.cc View 1 2 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
scottmg
5 years, 8 months ago (2015-04-08 23:18:31 UTC) #1
jungshik at Google
On 2015/04/08 23:18:31, scottmg wrote: LGTM. Thanks. One very unlikely possibility (because we're all using ...
5 years, 8 months ago (2015-04-09 18:20:41 UTC) #2
scottmg
On 2015/04/09 18:20:41, Jungshik at google wrote: > On 2015/04/08 23:18:31, scottmg wrote: > > ...
5 years, 8 months ago (2015-04-09 18:25:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076623004/20001
5 years, 8 months ago (2015-04-09 18:26:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/10664)
5 years, 8 months ago (2015-04-09 23:55:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076623004/20001
5 years, 8 months ago (2015-04-10 01:15:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/10857)
5 years, 8 months ago (2015-04-10 07:23:24 UTC) #11
scottmg
On 2015/04/10 07:23:24, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-10 15:03:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076623004/40001
5 years, 8 months ago (2015-04-24 22:53:14 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-25 01:19:21 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 01:20:12 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7a33682428a1fb621da6f540ae1fce1cb2200d12
Cr-Commit-Position: refs/heads/master@{#326946}

Powered by Google App Engine
This is Rietveld 408576698