Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1076533002: Fix some shutdown problems in tab capture performance tests. (Closed)

Created:
5 years, 8 months ago by hubbe
Modified:
5 years, 8 months ago
Reviewers:
miu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some shutdown problems in tab capture performance tests. As usual, the RunUntilIdle() call causes problems. Calling stop() on the webrtc stream apparently doesn't propagate back to the capture, so make sure that we call stop() on the capture stream explicitly. Also, raise frame rate to 60 fps. Not entirely sure if this will fix the attached bug or not, but either way it's a problem that should be fixed. BUG=474808 Committed: https://crrev.com/f8c0510631f52de6ca585fdce1ac171b37f36244 Cr-Commit-Position: refs/heads/master@{#324325}

Patch Set 1 #

Patch Set 2 : fix fps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/performance.js View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hubbe
5 years, 8 months ago (2015-04-08 19:08:00 UTC) #2
miu
lgtm
5 years, 8 months ago (2015-04-08 20:25:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076533002/20001
5 years, 8 months ago (2015-04-08 20:27:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 01:02:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:04:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8c0510631f52de6ca585fdce1ac171b37f36244
Cr-Commit-Position: refs/heads/master@{#324325}

Powered by Google App Engine
This is Rietveld 408576698