Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: Source/modules/accessibility/AXScrollView.cpp

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXScrollView.cpp
diff --git a/Source/modules/accessibility/AXScrollView.cpp b/Source/modules/accessibility/AXScrollView.cpp
index cbadd2274faefe01931b113eb6401c589bce387b..fb5380922743fa4b5c1466bdec58edeca24b0565 100644
--- a/Source/modules/accessibility/AXScrollView.cpp
+++ b/Source/modules/accessibility/AXScrollView.cpp
@@ -144,7 +144,7 @@ void AXScrollView::clearChildren()
m_horizontalScrollbar = nullptr;
}
-bool AXScrollView::computeAccessibilityIsIgnored() const
+bool AXScrollView::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const
{
// We just want to match whatever's returned by our web area, which is a child of this
// object. Normally cached attribute values may only search up the tree. We can't just
@@ -157,10 +157,13 @@ bool AXScrollView::computeAccessibilityIsIgnored() const
m_lastModificationCount = axObjectCache()->modificationCount();
AXObject* webArea = webAreaObject();
- if (webArea)
- return webArea->accessibilityIsIgnored();
+ if (!webArea)
+ return true;
+
+ if (ignoredReasons)
+ return webArea->computeAccessibilityIsIgnored(ignoredReasons);
- return true;
+ return webArea->accessibilityIsIgnored();
}
void AXScrollView::addChildren()

Powered by Google App Engine
This is Rietveld 408576698