Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: Source/modules/accessibility/AXMediaControls.cpp

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXMediaControls.cpp
diff --git a/Source/modules/accessibility/AXMediaControls.cpp b/Source/modules/accessibility/AXMediaControls.cpp
index 067ee6fe7483ce15b979d6372bac7b1d8523f3fb..3f43e2615365fbf52eda8f88f7f41a4ab5d3d48c 100644
--- a/Source/modules/accessibility/AXMediaControls.cpp
+++ b/Source/modules/accessibility/AXMediaControls.cpp
@@ -150,12 +150,12 @@ String AccessibilityMediaControl::deprecatedHelpText() const
}
}
-bool AccessibilityMediaControl::computeAccessibilityIsIgnored() const
+bool AccessibilityMediaControl::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const
{
if (!m_layoutObject || !m_layoutObject->style() || m_layoutObject->style()->visibility() != VISIBLE || controlType() == MediaTimelineContainer)
return true;
- return accessibilityIsIgnoredByDefault();
+ return accessibilityIsIgnoredByDefault(ignoredReasons);
}
AccessibilityRole AccessibilityMediaControl::roleValue() const
@@ -206,9 +206,9 @@ String AXMediaControlsContainer::deprecatedHelpText() const
return queryString(isControllingVideoElement() ? WebLocalizedString::AXMediaVideoElementHelp : WebLocalizedString::AXMediaAudioElementHelp);
}
-bool AXMediaControlsContainer::computeAccessibilityIsIgnored() const
+bool AXMediaControlsContainer::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const
{
- return accessibilityIsIgnoredByDefault();
+ return accessibilityIsIgnoredByDefault(ignoredReasons);
}
//
@@ -259,7 +259,7 @@ PassRefPtr<AXObject> AccessibilityMediaTimeDisplay::create(LayoutObject* layoutO
return adoptRef(new AccessibilityMediaTimeDisplay(layoutObject, axObjectCache));
}
-bool AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored() const
+bool AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const
{
if (!m_layoutObject || !m_layoutObject->style() || m_layoutObject->style()->visibility() != VISIBLE)
return true;
@@ -267,7 +267,7 @@ bool AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored() const
if (!m_layoutObject->style()->width().value())
return true;
- return accessibilityIsIgnoredByDefault();
+ return accessibilityIsIgnoredByDefault(ignoredReasons);
}
String AccessibilityMediaTimeDisplay::deprecatedAccessibilityDescription() const

Powered by Google App Engine
This is Rietveld 408576698