Source/modules/accessibility/AXListBoxOption.cpp - Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXListBoxOption.cpp

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/accessibility/AXLayoutObject.cpp ('K') | « Source/modules/accessibility/AXListBoxOption.h ('k') | Source/modules/accessibility/AXMediaControls.h » ('j') | Source/modules/accessibility/AXObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXListBoxOption.cpp

diff --git a/Source/modules/accessibility/AXListBoxOption.cpp b/Source/modules/accessibility/AXListBoxOption.cpp

index ae3e4afc062ed7ef56f56429f8d4ca5289a46083..ad80498d911ddaa1595d440565ba2a343f861346 100644

--- a/Source/modules/accessibility/AXListBoxOption.cpp

+++ b/Source/modules/accessibility/AXListBoxOption.cpp

@@ -113,12 +113,12 @@ bool AXListBoxOption::isSelectedOptionActive() const

return listBoxParentNode->activeSelectionEndListIndex() == listBoxOptionIndex();

}

-bool AXListBoxOption::computeAccessibilityIsIgnored() const

+bool AXListBoxOption::computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> ignoredReasons) const

{

if (!node())

return true;

- if (accessibilityIsIgnoredByDefault())

+ if (accessibilityIsIgnoredByDefault(ignoredReasons))

return true;

return false;