Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js - Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a catch-all return to ignoredReasonName Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/accessibility/accessibilityNode.css ('k') | Source/devtools/front_end/elements/ElementsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

index cd84290db3a7732bf4560efe58dc92b08c642384..2b35762929714f08b2f0e08664a23a1be2ced8bf 100644

--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

@@ -163,22 +163,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {

} else

message = "Paused on a \"%s\" breakpoint set on %s.";

- var element = createElement("span");

- var formatters = {

- s: function(substitution)

- {

- return substitution;

- }

- };

- function append(a, b)

- {

- if (typeof b === "string")

- b = createTextNode(b);

- else if (b.shadowRoot)

- b = createTextNode(b.shadowRoot.lastChild.textContent);

- element.appendChild(b);

- }

- WebInspector.formatLocalized(message, substitutions, formatters, "", append);

+ var element = WebInspector.formatLocalized(message, substitutions, "");

callback(element);