Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: pfeldman review comments (take 3) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 2e027a5a8a1b2e2459fb97b6a475c0afa70f08c1..87a32bf10ea2b40fc12054d3567646b490382283 100644
--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -163,22 +163,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
} else
message = "Paused on a \"%s\" breakpoint set on %s.";
- var element = createElement("span");
- var formatters = {
- s: function(substitution)
- {
- return substitution;
- }
- };
- function append(a, b)
- {
- if (typeof b === "string")
- b = createTextNode(b);
- else if (b.shadowRoot)
- b = createTextNode(b.shadowRoot.lastChild.textContent);
- element.appendChild(b);
- }
- WebInspector.formatLocalized(message, substitutions, formatters, "", append);
+ var element = WebInspector.formatLocalized(message, substitutions, "");
callback(element);
},

Powered by Google App Engine
This is Rietveld 408576698