Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1076453004: Show reasons why nodes are ignored in accessibility sidebar (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp
index 0f6e038c2139436ca348f5a6ef32b38e3525b41b..96c4f878a617d24e262ec59fc1cb9045fddd776a 100644
--- a/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/Source/modules/accessibility/AXLayoutObject.cpp
@@ -590,14 +590,13 @@ bool AXLayoutObject::computeAccessibilityIsIgnored() const
if (m_layoutObject->isBR())
return false;
- // NOTE: BRs always have text boxes now, so the text box check here can be removed
if (m_layoutObject->isText()) {
// static text beneath MenuItems and MenuButtons are just reported along with the menu item, so it's ignored on an individual level
AXObject* parent = parentObjectUnignored();
if (parent && (parent->ariaRoleAttribute() == MenuItemRole || parent->ariaRoleAttribute() == MenuButtonRole))
return true;
LayoutText* layoutText = toLayoutText(m_layoutObject);
- if (m_layoutObject->isBR() || !layoutText->firstTextBox())
+ if (!layoutText->firstTextBox())
return true;
// Don't ignore static text in editable text controls.

Powered by Google App Engine
This is Rietveld 408576698