Show reasons why nodes are ignored in accessibility sidebar

Source/modules/accessibility/AXObject.h

 /*
  * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 12 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AXObject_h
 #define AXObject_h
 
+#include "core/InspectorTypeBuilder.h"
 #include "core/editing/VisiblePosition.h"
 #include "modules/ModulesExport.h"
 #include "platform/geometry/FloatQuad.h"
 #include "platform/geometry/LayoutRect.h"
 #include "wtf/Forward.h"
 #include "wtf/RefPtr.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
@@ skipping 393 matching lines @@
     virtual bool isVisible() const { return true; }
     virtual bool isVisited() const { return false; }
 
     // Check whether certain properties can be modified.
     virtual bool canSetFocusAttribute() const { return false; }
     virtual bool canSetValueAttribute() const { return false; }
     virtual bool canSetSelectedAttribute() const { return false; }
 
     // Whether objects are ignored, i.e. not included in the tree.
     bool accessibilityIsIgnored() const;
-    bool accessibilityIsIgnoredByDefault() const;
+    virtual bool computeAccessibilityIsIgnored(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> = PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>()) const { return true; }

[dmazzoni, 2015/04/15 17:00:02]

How about a typedef for
PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>

[aboxhall, 2015/04/15 17:55:46]

Done.

+    bool accessibilityIsIgnoredByDefault(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> = PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>()) const;

[dmazzoni, 2015/04/15 17:00:02]

accessibilityIsIgnoredByDefault hardly does anything - it's a left over from
WebKit when it did something different on each platform.

Maybe consider first doing a quick cleanup change to get rid of it and fold it
into computeAccessibilityIsIgnored?

[aboxhall, 2015/04/15 17:55:46]

Ok, working on that now.

     AXObjectInclusion accessibilityPlatformIncludesObject() const;
-    virtual AXObjectInclusion defaultObjectInclusion() const;
+    virtual AXObjectInclusion defaultObjectInclusion(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> = PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>()) const;
     bool isInertOrAriaHidden() const;
     const AXObject* ariaHiddenRoot() const;
-    bool computeIsInertOrAriaHidden() const;
-    bool isDescendantOfBarrenParent() const;
-    bool computeIsDescendantOfBarrenParent() const;
+    bool computeIsInertOrAriaHidden(PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>> = PassRefPtr<TypeBuilder::Array<TypeBuilder::Accessibility::AXProperty>>()) const;
+    bool isDescendantOfLeafNode() const;

[dmazzoni, 2015/04/15 17:00:02]

This sounds great, but let's split the renames into a separate (trivial) change

[aboxhall, 2015/04/15 17:55:46]

I can do that, but note that it's a type change for the related method as well
as a rename (and this change won't work without the latter).

+    AXObject* leafNodeAncestor() const;
     bool isDescendantOfDisabledNode() const;
-    bool computeIsDescendantOfDisabledNode() const;
+    const AXObject* disabledAncestor() const;
     bool lastKnownIsIgnoredValue();
     void setLastKnownIsIgnoredValue(bool);
 
     //
     // Deprecated text alternative calculation API. All of these will be replaced
     // with the new API, below (under "New text alternative calculation API".
     //
 
     virtual bool deprecatedExposesTitleUIElement() const { return true; }
     virtual AXObject* deprecatedTitleUIElement() const { return 0; }
@@ skipping 75 matching lines @@
     virtual void ariaFlowToElements(AccessibilityChildrenVector&) const { }
     virtual void ariaControlsElements(AccessibilityChildrenVector&) const { }
     virtual void ariaOwnsElements(AccessibilityChildrenVector& owns) const { };
     virtual bool ariaHasPopup() const { return false; }
     bool isMultiline() const;
     virtual String ariaLabeledByAttribute() const { return String(); }
     bool ariaPressedIsPresent() const;
     virtual AccessibilityRole ariaRoleAttribute() const { return UnknownRole; }
     virtual bool ariaRoleHasPresentationalChildren() const { return false; }
     virtual AccessibilityOptionalBool isAriaGrabbed() const { return OptionalBoolUndefined; }
-    virtual bool isPresentationalChildOfAriaRole() const { return false; }
+    virtual AXObject* ancestorForWhichThisIsAPresentationalChild() const { return 0; }
     virtual bool shouldFocusActiveDescendant() const { return false; }
     bool supportsARIAAttributes() const;
     virtual bool supportsARIADragging() const { return false; }
     virtual bool supportsARIADropping() const { return false; }
     virtual bool supportsARIAFlowTo() const { return false; }
     virtual bool supportsARIAOwns() const { return false; }
     bool supportsRangeValue() const;
     virtual SortDirection sortDirection() const { return SortDirectionUndefined; }
 
     // ARIA trees.
@@ skipping 112 matching lines @@
     bool hasInheritedPresentationalRole() const { return m_cachedHasInheritedPresentationalRole; }
 
 protected:
     AXID m_id;
     AccessibilityChildrenVector m_children;
     mutable bool m_haveChildren;
     AccessibilityRole m_role;
     AXObjectInclusion m_lastKnownIsIgnoredValue;
     LayoutRect m_explicitElementRect;
 
-    virtual bool computeAccessibilityIsIgnored() const { return true; }
-    virtual bool computeHasInheritedPresentationalRole() const { return false; }
+    virtual AXObject* inheritsPresentationalRoleFrom() const { return 0; }
 
     // If this object itself scrolls, return its ScrollableArea.
     virtual ScrollableArea* getScrollableAreaIfScrollable() const { return 0; }
     virtual void scrollTo(const IntPoint&) const { }
 
     AccessibilityRole buttonRoleType() const;
 
     bool allowsTextRanges() const { return isTextControl(); }
     unsigned getLengthForTextRange() const { return text().length(); }
 
     bool m_detached;
 
     mutable AXObject* m_parent;
 
     // The following cached attribute values (the ones starting with m_cached*)
     // are only valid if m_lastModificationCount matches AXObjectCacheImpl::modificationCount().
     mutable int m_lastModificationCount;
     mutable bool m_cachedIsIgnored : 1;
     mutable bool m_cachedIsInertOrAriaHidden : 1;
-    mutable bool m_cachedIsDescendantOfBarrenParent : 1;
+    mutable bool m_cachedIsDescendantOfLeafNode : 1;
     mutable bool m_cachedIsDescendantOfDisabledNode : 1;
     mutable bool m_cachedHasInheritedPresentationalRole : 1;
     mutable const AXObject* m_cachedLiveRegionRoot;
 
     AXObjectCacheImpl* m_axObjectCache;
 
     // Updates the cached attribute values. This may be recursive, so to prevent deadlocks,
     // functions called here may only search up the tree (ancestors), not down.
     void updateCachedAttributeValuesIfNeeded() const;
 
 private:
     static bool includesARIAWidgetRole(const String&);
     static bool hasInteractiveARIAAttribute(const Element&);
 };
 
 #define DEFINE_AX_OBJECT_TYPE_CASTS(thisType, predicate) \
     DEFINE_TYPE_CASTS(thisType, AXObject, object, object->predicate, object.predicate)
 
 } // namespace blink
 
 #endif // AXObject_h