content/browser/renderer_host/input/motion_event_android.cc - Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/motion_event_android.cc

Issue 1076443002: Removed obsolete float_util.h as VS2013 supports standards well enough. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_event_impl.cc ('K') | « content/browser/android/java/gin_java_method_invocation_helper.cc ('k') | content/browser/renderer_host/input/motion_event_android_unittest.cc » ('j') | content/child/v8_value_converter_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/motion_event_android.cc

diff --git a/content/browser/renderer_host/input/motion_event_android.cc b/content/browser/renderer_host/input/motion_event_android.cc

index 3f18f95561b3d650ccc3b3d36bd040f6f12f587f..bed040a7a9b6b65655a0713b2ff1751758f027ff 100644

--- a/content/browser/renderer_host/input/motion_event_android.cc

+++ b/content/browser/renderer_host/input/motion_event_android.cc

@@ -5,9 +5,9 @@

#include "content/browser/renderer_host/input/motion_event_android.h"

#include <android/input.h>

+#include <cmath>

Mark Mentovai 2015/04/08 18:04:37 Leave a blank line between C system headers and C+

Mateusz Szymański 2015/04/09 07:32:51 Done.

#include "base/android/jni_android.h"

-#include "base/float_util.h"

#include "jni/MotionEvent_jni.h"

#include "ui/events/event_constants.h"

@@ -92,7 +92,7 @@ base::TimeTicks FromAndroidTime(int64 time_ms) {

}

float ToValidFloat(float x) {

- if (base::IsNaN(x))

+ if (std::isnan(x))

return 0.f;

// Wildly large orientation values have been observed in the wild after device