Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 107643002: Revert 239102 "Move build/build_config_functions.h to sandbox/" (Closed)

Created:
7 years ago by rlarocque
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 239102 "Move build/build_config_functions.h to sandbox/" > Move build/build_config_functions.h to sandbox/ > > There is not much support for build/build_config_functions.h, > as highlighted in http://goo.gl/3ufXOJ. Move it away. > > R=jww@chromium.org > > Review URL: https://codereview.chromium.org/106163008 TBR=jln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -88 lines) Patch
M trunk/src/build/build_config.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + trunk/src/build/build_config_functions.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/sandbox/linux/seccomp-bpf/bpf_tests.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/sandbox/linux/services/build_config_functions.h View 1 chunk +0 lines, -86 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rlarocque
7 years ago (2013-12-06 02:08:57 UTC) #1
rlarocque
Committed patchset #1 manually as r239105.
7 years ago (2013-12-06 02:09:12 UTC) #2
rlarocque
7 years ago (2013-12-06 02:15:31 UTC) #3
Message was sent while issue was closed.
On 2013/12/06 02:09:12, rlarocque wrote:
> Committed patchset #1 manually as r239105.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Builder/b...

[993/11984] CXX obj/net/http/net.http_pipelined_stream.o
FAILED: clang++ -MMD -MF
obj/sandbox/linux/seccomp-bpf/sandbox_linux_unittests.sandbox_bpf_unittest.o.d
-DANGLE_DX11 -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
-DCHROMIUM_BUILD -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN
-DGTK_DISABLE_SINGLE_INCLUDES=1 -DUSE_XI2_MT=2 -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DUSE_UDEV
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DMEMORY_TOOL_REPLACES_ALLOCATOR
-DADDRESS_SANITIZER -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../..
-I../../testing/gtest/include -fstack-protector --param=ssp-buffer-size=4
-Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load
-Xclang
/b/build/slave/Linux_ASAN_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-fno-omit-frame-pointer -gline-tables-only -fsanitize=address -w -fsanitize=leak
-O2 -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare -std=gnu++11  -c
../../sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc -o
obj/sandbox/linux/seccomp-bpf/sandbox_linux_unittests.sandbox_bpf_unittest.o
In file included from
../../sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc:25:
../../sandbox/linux/seccomp-bpf/bpf_tests.h:96:12:error: use of undeclared
identifier 'build'
      if (!build::IsAndroid() && !IsRunningOnValgrind() &&
           ^
../../sandbox/linux/seccomp-bpf/bpf_tests.h:97:12:error: use of undeclared
identifier 'build'
          !build::IsArchitectureARM()) {
           ^
../../sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc:263:7:error: use of
undeclared identifier 'build'
  if (build::IsAndroid() && setgid(0) != -1) {
      ^
3 errors generated.
FAILED: clang++ -MMD -MF
obj/sandbox/linux/seccomp-bpf/sandbox_linux_unittests.syscall_unittest.o.d
-DANGLE_DX11 -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
-DCHROMIUM_BUILD -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN
-DGTK_DISABLE_SINGLE_INCLUDES=1 -DUSE_XI2_MT=2 -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DUSE_UDEV
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DUNIT_TEST -DGTEST_HAS_RTTI=0
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DMEMORY_TOOL_REPLACES_ALLOCATOR
-DADDRESS_SANITIZER -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../..
-I../../testing/gtest/include -fstack-protector --param=ssp-buffer-size=4
-Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load
-Xclang
/b/build/slave/Linux_ASAN_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libpng12 -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-fno-omit-frame-pointer -gline-tables-only -fsanitize=address -w -fsanitize=leak
-O2 -fdata-sections -ffunction-sections -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare -std=gnu++11  -c
../../sandbox/linux/seccomp-bpf/syscall_unittest.cc -o
obj/sandbox/linux/seccomp-bpf/sandbox_linux_unittests.syscall_unittest.o
In file included from ../../sandbox/linux/seccomp-bpf/syscall_unittest.cc:15:
../../sandbox/linux/seccomp-bpf/bpf_tests.h:96:12:error: use of undeclared
identifier 'build'
      if (!build::IsAndroid() && !IsRunningOnValgrind() &&
           ^
../../sandbox/linux/seccomp-bpf/bpf_tests.h:97:12:error: use of undeclared
identifier 'build'
          !build::IsArchitectureARM()) {
           ^
2 errors generated.
ninja: build stopped: subcommand failed.

Powered by Google App Engine
This is Rietveld 408576698