DescriptionRevert of Cache --whitelisted-extension-id in SimpleFeature. (patchset #13 id:240001 of https://codereview.chromium.org/1047943002/)
Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=476061
Causing consistent errors on a variety of memory bots in both InitValueManifestTest.InitFromValueInvalid and LauncherPageManifestTest.ValidLauncherPage tests.
Original issue's description:
> Cache --whitelisted-extension-id in SimpleFeature.
>
> During startup, CommandLine::HasSwitch(kWhitelistedExtensionID) is
> called ~1000 times by SimpleFeature. It is the most common switch
> lookup, the second being kAppsGalleryUpdateUrl at ~300 times.
>
> Caching this avoids allocating and copying the string each time.
>
> BUG=471976
>
> Committed: https://crrev.com/16ca320592ce7ef6cd36500da6e670cc645781cd
> Cr-Commit-Position: refs/heads/master@{#324583}
TBR=tapted@chromium.org,kalman@chromium.org,mfoltz@chromium.org,jackhou@chromium.org
BUG=471976
Committed: https://crrev.com/473f21ef56a6fa05bfe0afc79fe5893d3ae804b4
Cr-Commit-Position: refs/heads/master@{#324695}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|