Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1076393002: Revert of Cache --whitelisted-extension-id in SimpleFeature. (Closed)

Created:
5 years, 8 months ago by Mike Lerman
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cache --whitelisted-extension-id in SimpleFeature. (patchset #13 id:240001 of https://codereview.chromium.org/1047943002/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=476061 Causing consistent errors on a variety of memory bots in both InitValueManifestTest.InitFromValueInvalid and LauncherPageManifestTest.ValidLauncherPage tests. Original issue's description: > Cache --whitelisted-extension-id in SimpleFeature. > > During startup, CommandLine::HasSwitch(kWhitelistedExtensionID) is > called ~1000 times by SimpleFeature. It is the most common switch > lookup, the second being kAppsGalleryUpdateUrl at ~300 times. > > Caching this avoids allocating and copying the string each time. > > BUG=471976 > > Committed: https://crrev.com/16ca320592ce7ef6cd36500da6e670cc645781cd > Cr-Commit-Position: refs/heads/master@{#324583} TBR=tapted@chromium.org,kalman@chromium.org,mfoltz@chromium.org,jackhou@chromium.org BUG=471976 Committed: https://crrev.com/473f21ef56a6fa05bfe0afc79fe5893d3ae804b4 Cr-Commit-Position: refs/heads/master@{#324695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -98 lines) Patch
M chrome/browser/extensions/permission_message_combinations_unittest.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/extensions/test_extension_environment.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/test_extension_environment.cc View 2 chunks +14 lines, -35 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.h View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 4 chunks +14 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Lerman
Created Revert of Cache --whitelisted-extension-id in SimpleFeature.
5 years, 8 months ago (2015-04-10 19:58:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076393002/1
5 years, 8 months ago (2015-04-10 20:43:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 22:16:26 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 22:17:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/473f21ef56a6fa05bfe0afc79fe5893d3ae804b4
Cr-Commit-Position: refs/heads/master@{#324695}

Powered by Google App Engine
This is Rietveld 408576698