Issue 1076313003: Remove completely-unused CSSValueKeywords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1076313003: Remove completely-unused CSSValueKeywords (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
Hixie

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove completely-unused CSSValueKeywords I wrote a little script to try removing each non-comment line of this file and re-compiling. This was the result of said script. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9b73d2340c13f3835556ab89ec8d698e8f0a4fee

Patch Set 2 : per review #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -34 lines)			Patch
	M	sky/engine/core/css/CSSValueKeywords.in	View	1	11 chunks	+5 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

Feel free to ignore the comments in parentheses. LGTM. https://codereview.chromium.org/1076313003/diff/1/sky/engine/core/css/CSSValueKeywords.in File sky/engine/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/1076313003/diff/1/sky/engine/core/css/CSSValueKeywords.in#newcode111 sky/engine/core/css/CSSValueKeywords.in:111: ...

5 years, 8 months ago (2015-04-10 18:30:01 UTC) #2

eseidel

5 years, 8 months ago (2015-04-10 18:54:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9b73d2340c13f3835556ab89ec8d698e8f0a4fee (presubmit successful).

Expand Messages | Collapse Messages

Issue 1076313003: Remove completely-unused CSSValueKeywords (Closed)

Description

Patch Set 1 #

Patch Set 2 : per review #

Messages