Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2337)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 1076273002: Add interstitial info to certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: redo based on refactoring in crrev.com/1117173004 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index c81e436e986cc9671867d0a09c767795e878495f..cdb0f160367133c7a5d5ebd3636a3ca0ed9a7a61 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -587,7 +587,7 @@ void SSLBlockingPage::OnProceed() {
// Finish collecting information about invalid certificates, if the
// user opted in to.
- FinishCertCollection();
+ FinishCertCollection(CertificateErrorReport::USER_PROCEEDED);
RecordSSLExpirationPageEventState(
expired_but_previously_allowed_, true, overridable_);
@@ -601,7 +601,7 @@ void SSLBlockingPage::OnDontProceed() {
// Finish collecting information about invalid certificates, if the
// user opted in to.
- FinishCertCollection();
+ FinishCertCollection(CertificateErrorReport::USER_DID_NOT_PROCEED);
RecordSSLExpirationPageEventState(
expired_but_previously_allowed_, false, overridable_);
@@ -650,7 +650,8 @@ std::string SSLBlockingPage::GetSamplingEventName() const {
return event_name;
}
-void SSLBlockingPage::FinishCertCollection() {
+void SSLBlockingPage::FinishCertCollection(
+ CertificateErrorReport::ProceedDecision user_proceeded) {
if (!ShouldShowCertificateReporterCheckbox())
return;
@@ -667,6 +668,21 @@ void SSLBlockingPage::FinishCertCollection() {
std::string serialized_report;
CertificateErrorReport report(request_url().host(), ssl_info_);
+ CertificateErrorReport::InterstitialReason report_interstitial_reason;
+ switch (interstitial_reason_) {
+ case SSL_REASON_SSL:
+ report_interstitial_reason = CertificateErrorReport::INTERSTITIAL_SSL;
+ break;
+ case SSL_REASON_BAD_CLOCK:
+ report_interstitial_reason = CertificateErrorReport::INTERSTITIAL_CLOCK;
+ break;
+ }
+
+ report.SetInterstitialInfo(
+ report_interstitial_reason, user_proceeded,
+ overridable_ ? CertificateErrorReport::INTERSTITIAL_OVERRIDABLE
+ : CertificateErrorReport::INTERSTITIAL_NOT_OVERRIDABLE);
+
if (!report.Serialize(&serialized_report)) {
LOG(ERROR) << "Failed to serialize certificate report.";
return;
« chrome/browser/ssl/ssl_blocking_page.h ('K') | « chrome/browser/ssl/ssl_blocking_page.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698