Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1076273002: Add interstitial info to certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index d6eb171774873914cd23bcd4eea8d6be21f81bf4..94633c9f8cb8e8584a24dc200fa25fcf2d96024c 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/interstitials/security_interstitial_page_test_utils.h"
+#include "chrome/browser/net/cert_logger.pb.h"
#include "chrome/browser/net/certificate_error_reporter.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/safe_browsing/ping_manager.h"
@@ -208,11 +209,11 @@ class MockReporter : public CertificateErrorReporter {
upload_url,
cookies_preference) {}
- void SendReport(CertificateErrorReporter::ReportType type,
- const std::string& hostname,
- const net::SSLInfo& ssl_info) override {
+ void SendReport(
+ CertificateErrorReporter::ReportType type,
+ const chrome_browser_net::CertLoggerRequest& report) override {
EXPECT_EQ(CertificateErrorReporter::REPORT_TYPE_EXTENDED_REPORTING, type);
- latest_hostname_reported_ = hostname;
+ latest_hostname_reported_ = report.hostname();
}
const std::string& latest_hostname_reported() {
@@ -245,12 +246,12 @@ class MockSSLCertReporter : public SSLCertReporter {
~MockSSLCertReporter() override { EXPECT_EQ(expect_report_, reported_); }
// SSLCertReporter implementation
- void ReportInvalidCertificateChain(const std::string& hostname,
- const net::SSLInfo& ssl_info) override {
+ void SendReport(
+ const chrome_browser_net::CertLoggerRequest& report) override {
reported_ = true;
if (expect_report_) {
safe_browsing_ui_manager_->ReportInvalidCertificateChain(
- hostname, ssl_info, report_sent_callback_);
+ report, report_sent_callback_);
}
}

Powered by Google App Engine
This is Rietveld 408576698