Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 1076273002: Add interstitial info to certificate reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index 382d103a3626dc006e0be749357e4ebb0f783662..47c29c9688fe498a7b51fd30e0d410f1b136cb21 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -13,6 +13,7 @@
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/net/cert_logger.pb.h"
#include "chrome/browser/safe_browsing/malware_details.h"
#include "chrome/browser/safe_browsing/metadata.pb.h"
#include "chrome/browser/safe_browsing/ping_manager.h"
@@ -215,15 +216,14 @@ void SafeBrowsingUIManager::ReportSafeBrowsingHit(
}
void SafeBrowsingUIManager::ReportInvalidCertificateChain(
- const std::string& hostname,
- const net::SSLInfo& ssl_info,
+ const chrome_browser_net::CertLoggerRequest& report,
const base::Closure& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
BrowserThread::PostTaskAndReply(
BrowserThread::IO, FROM_HERE,
base::Bind(
&SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread, this,
- hostname, ssl_info),
+ report),
callback);
}
@@ -261,8 +261,7 @@ void SafeBrowsingUIManager::ReportSafeBrowsingHitOnIOThread(
}
void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
- const std::string& hostname,
- const net::SSLInfo& ssl_info) {
+ const chrome_browser_net::CertLoggerRequest& report) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// The service may delete the ping manager (i.e. when user disabling service,
@@ -270,8 +269,7 @@ void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
if (!sb_service_ || !sb_service_->ping_manager())
return;
- sb_service_->ping_manager()->ReportInvalidCertificateChain(hostname,
- ssl_info);
+ sb_service_->ping_manager()->ReportInvalidCertificateChain(report);
}
// If the user had opted-in to send MalwareDetails, this gets called

Powered by Google App Engine
This is Rietveld 408576698