Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 107623002: Use the NativeTheme to create the text color for text during the generated card animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use addition to make the alpha-calculation more grokable. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 0d704051ea9f9785598a9b5a570c8cb277dc6a5c..73eab9c6c852876e1a72c9fe9d645a8193987945 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -88,6 +88,7 @@
#include "ui/gfx/canvas.h"
#include "ui/gfx/image/image_skia_operations.h"
#include "ui/gfx/skia_util.h"
+#include "ui/native_theme/native_theme.h"
namespace autofill {
@@ -773,7 +774,8 @@ bool AutofillDialogControllerImpl::IsDialogButtonEnabled(
return !is_submitting_ || IsSubmitPausedOn(wallet::VERIFY_CVV);
}
-DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay() {
+DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay(
+ const ui::NativeTheme* theme) {
bool show_wallet_interstitial = IsPayingWithWallet() && is_submitting_ &&
!(full_wallet_ && !full_wallet_->required_actions().empty());
if (!show_wallet_interstitial) {
@@ -785,7 +787,8 @@ DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay() {
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
DialogOverlayState state;
state.string.font = rb.GetFont(ui::ResourceBundle::BaseFont).DeriveFont(3);
- state.string.text_color = SK_ColorDKGRAY;
+ state.string.text_color = theme->GetSystemColor(
Evan Stade 2013/12/17 18:53:10 just remove text_color from state.string, imo
Sheridan Rawlins 2013/12/17 23:01:12 Done.
+ ui::NativeTheme::kColorId_TextfieldReadOnlyColor);
const SkColor start_top_color = SkColorSetRGB(0xD6, 0xD6, 0xD6);
const SkColor start_bottom_color = SkColorSetRGB(0x98, 0x98, 0x98);

Powered by Google App Engine
This is Rietveld 408576698