chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm - Issue 107623002: Use the NativeTheme to create the text color for text during the generated card animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

Issue 107623002: Use the NativeTheme to create the text color for text during the generated card animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed mac to use the GRAY constant that was previously set in the autofill_dialog_controller_impl. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_types.h ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

index 8cff21868013d6e3e1b1722ff45ab43d3e68b7c6..633f596ab32374d35cba4b72977854fd5cec41cb 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm

@@ -11,6 +11,7 @@

#include "chrome/browser/ui/autofill/autofill_dialog_view_delegate.h"

#include "chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h"

#include "skia/ext/skia_utils_mac.h"

+#include "third_party/skia/include/core/SkColor.h"

namespace {

@@ -95,7 +96,7 @@ SkColor kSubtleBorderColor = 0xffdfdfdf;

// We probably want to look at other multi-line messages somewhere.

[label_ setFont:message.font.GetNativeFont()];

[label_ setStringValue:base::SysUTF16ToNSString(message.text)];

- [label_ setTextColor:gfx::SkColorToCalibratedNSColor(message.text_color)];

+ [label_ setTextColor:gfx::SkColorToCalibratedNSColor(SK_ColorDKGRAY)];

groby-ooo-7-16 2014/01/08 18:44:53 If we don't use hand-tuned colors any more, I sugg

Sheridan Rawlins 2014/01/08 23:58:41 Done.

// Resize only height, preserve width. This guarantees text stays centered in

// the dialog.

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_types.h ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('j') | no next file with comments »