Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 107623002: Use the NativeTheme to create the text color for text during the generated card animation. (Closed)

Created:
7 years ago by Sheridan Rawlins
Modified:
6 years, 11 months ago
CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Use the NativeTheme to create the text color for text during the generated card animation. Also adjust the background so that darker colors are lighter and by a larger amount if really dark. BUG=320899 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244083

Patch Set 1 #

Patch Set 2 : Adjust the background color in addition to the text color taking into account dark colors need to b… #

Patch Set 3 : Grow alpha for shading & border of overlay background as it approaches black. #

Total comments: 2

Patch Set 4 : Use addition to make the alpha-calculation more grokable. #

Total comments: 2

Patch Set 5 : rebase #

Patch Set 6 : Removing text_color as per Evan's suggestion. #

Patch Set 7 : Remove unused header. #

Total comments: 2

Patch Set 8 : Add a comment to describe the alpha blend math. #

Patch Set 9 : Fixed mac to use the GRAY constant that was previously set in the autofill_dialog_controller_impl. #

Total comments: 2

Patch Set 10 : Use mac's darkGrayColor rather than converting a skia-based color. #

Patch Set 11 : darkGrayColor is a method; call it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 5 6 7 8 9 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
groby-ooo-7-16
https://codereview.chromium.org/107623002/diff/40001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/107623002/diff/40001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode662 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:662: 7 - 15 * (background_luminance - 255) / 255); ...
7 years ago (2013-12-10 20:26:49 UTC) #1
Sheridan Rawlins
https://codereview.chromium.org/107623002/diff/40001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/107623002/diff/40001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode662 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:662: 7 - 15 * (background_luminance - 255) / 255); ...
7 years ago (2013-12-10 20:51:55 UTC) #2
Evan Stade
https://codereview.chromium.org/107623002/diff/60001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/107623002/diff/60001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode790 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:790: state.string.text_color = theme->GetSystemColor( just remove text_color from state.string, imo
7 years ago (2013-12-17 18:53:10 UTC) #3
Sheridan Rawlins
https://codereview.chromium.org/107623002/diff/60001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/107623002/diff/60001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode790 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:790: state.string.text_color = theme->GetSystemColor( On 2013/12/17 18:53:10, Evan Stade wrote: ...
7 years ago (2013-12-17 23:01:11 UTC) #4
Evan Stade
https://codereview.chromium.org/107623002/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/107623002/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode666 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:666: 10 + 20 * (255 - background_luminance) / 255); ...
6 years, 11 months ago (2014-01-03 02:00:54 UTC) #5
Sheridan Rawlins
https://codereview.chromium.org/107623002/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/107623002/diff/120001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode666 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:666: 10 + 20 * (255 - background_luminance) / 255); ...
6 years, 11 months ago (2014-01-04 01:58:28 UTC) #6
Evan Stade
lgtm
6 years, 11 months ago (2014-01-04 02:14:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/107623002/190001
6 years, 11 months ago (2014-01-07 18:53:47 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208607
6 years, 11 months ago (2014-01-07 19:33:10 UTC) #9
Sheridan Rawlins
groby@ can you PTAL @ the autofill_overlay_controller.mm change? I used the previous DKGRAY constant - ...
6 years, 11 months ago (2014-01-08 18:14:18 UTC) #10
groby-ooo-7-16
https://codereview.chromium.org/107623002/diff/480001/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm File chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm (right): https://codereview.chromium.org/107623002/diff/480001/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm#newcode99 chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm:99: [label_ setTextColor:gfx::SkColorToCalibratedNSColor(SK_ColorDKGRAY)]; If we don't use hand-tuned colors any ...
6 years, 11 months ago (2014-01-08 18:44:52 UTC) #11
Sheridan Rawlins
https://codereview.chromium.org/107623002/diff/480001/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm File chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm (right): https://codereview.chromium.org/107623002/diff/480001/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm#newcode99 chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm:99: [label_ setTextColor:gfx::SkColorToCalibratedNSColor(SK_ColorDKGRAY)]; On 2014/01/08 18:44:53, groby wrote: > If ...
6 years, 11 months ago (2014-01-08 23:58:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/107623002/640001
6 years, 11 months ago (2014-01-09 19:00:31 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44111
6 years, 11 months ago (2014-01-09 19:29:21 UTC) #14
groby-ooo-7-16
lgtm
6 years, 11 months ago (2014-01-10 01:34:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/107623002/640001
6 years, 11 months ago (2014-01-10 01:41:16 UTC) #16
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 04:53:16 UTC) #17
Message was sent while issue was closed. 
Change committed as 244083

Powered by Google App Engine
This is Rietveld 408576698