Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1076213002: Small refactor around futex.h. (Closed)

Created:
5 years, 8 months ago by hidehiko
Modified:
5 years, 8 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, jln (very slow on Chromium), Mark Seaborn, hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small refactor around futex.h. This is the preparation of seccomp-bpf implementation for nacl_helper_nonsfi. PNaCl toolchain does not provides linux/futex.h. This CL is the preparation to reuse android_futex.h for PNaCl toolchain, too. TEST=Ran bots. BUG=358465 Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591 Cr-Commit-Position: refs/heads/master@{#324996}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -90 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 2 chunks +1 line, -3 lines 0 comments Download
D sandbox/linux/system_headers/android_futex.h View 1 chunk +0 lines, -80 lines 0 comments Download
A + sandbox/linux/system_headers/linux_futex.h View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hidehiko
Hi, could you take a look? Thanks, - hidehiko
5 years, 8 months ago (2015-04-10 15:38:14 UTC) #2
mdempsky
lgtm
5 years, 8 months ago (2015-04-13 18:16:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076213002/20001
5 years, 8 months ago (2015-04-14 02:20:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-14 03:41:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591 Cr-Commit-Position: refs/heads/master@{#324996}
5 years, 8 months ago (2015-04-14 03:43:12 UTC) #8
dnicoara
5 years, 8 months ago (2015-04-15 17:22:26 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1084173003/ by dnicoara@chromium.org.

The reason for reverting is: Breaks ChromeOS veyron_jerry boot.

BUG=477352.

Powered by Google App Engine
This is Rietveld 408576698