Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1076173002: Files.app: Add metrics of RAW file loading time. (Closed)

Created:
5 years, 8 months ago by hirono
Modified:
5 years, 8 months ago
Reviewers:
Ben Kwa, Steve McKay
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add metrics of RAW file loading time. BUG=475034 TEST=None Committed: https://crrev.com/b3db409725e6a1f7f612ecf08115029aa14a6964 Cr-Commit-Position: refs/heads/master@{#325176}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fixed. #

Total comments: 4

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M ui/file_manager/file_manager/common/js/metrics_events.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/image_loader/compiled_resources.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/file_manager/image_loader/manifest.json View 1 chunk +9 lines, -2 lines 0 comments Download
M ui/file_manager/image_loader/request.js View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
hirono
PTAL, thanks!
5 years, 8 months ago (2015-04-10 11:02:17 UTC) #2
Ben Kwa
lgtm with a couple of minor notes. The one thing I'd want to double-check before ...
5 years, 8 months ago (2015-04-10 15:57:31 UTC) #3
hirono
I updated the CL as discussion. Please take another look, thanks! https://codereview.chromium.org/1076173002/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): ...
5 years, 8 months ago (2015-04-14 04:01:27 UTC) #5
Ben Kwa
One nit, but otherwise, still LGTM. Thanks! https://codereview.chromium.org/1076173002/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): https://codereview.chromium.org/1076173002/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js#newcode23 ui/file_manager/file_manager/common/js/metrics_events.js:23: RAW_IMAGE: 'Raw ...
5 years, 8 months ago (2015-04-14 14:47:28 UTC) #6
Steve McKay
https://codereview.chromium.org/1076173002/diff/20001/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): https://codereview.chromium.org/1076173002/diff/20001/ui/file_manager/file_manager/common/js/metrics_events.js#newcode149 ui/file_manager/file_manager/common/js/metrics_events.js:149: EXTRACT_JPEG_FROM_RAW: 'Extract JPEG From RAW' I thought we were ...
5 years, 8 months ago (2015-04-14 18:30:11 UTC) #7
hirono
Thanks! https://codereview.chromium.org/1076173002/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js File ui/file_manager/file_manager/common/js/metrics_events.js (right): https://codereview.chromium.org/1076173002/diff/1/ui/file_manager/file_manager/common/js/metrics_events.js#newcode23 ui/file_manager/file_manager/common/js/metrics_events.js:23: RAW_IMAGE: 'Raw Image' On 2015/04/14 14:47:28, Ben Kwa ...
5 years, 8 months ago (2015-04-15 01:57:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076173002/40001
5 years, 8 months ago (2015-04-15 01:57:37 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-15 02:33:39 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 02:34:26 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b3db409725e6a1f7f612ecf08115029aa14a6964
Cr-Commit-Position: refs/heads/master@{#325176}

Powered by Google App Engine
This is Rietveld 408576698