Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1076143002: Make ComposedTreeTraversal assert a node with Node::needsDistributionRecalc(). (Closed)

Created:
5 years, 8 months ago by hayato
Modified:
5 years, 8 months ago
Reviewers:
tkent, esprehn, kochi
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ComposedTreeTraversal assert a node with Node::needsDistributionRecalc(). This is a similar change to https://codereview.chromium.org/1058763002. Note that Node::needsDistributionRecalc() was updated in https://codereview.chromium.org/1068193002/ after that. BUG=473000 TEST=Existing Layout tests. No behavior change except for assertion. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/dom/shadow/ComposedTreeTraversal.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
hayato
PTAL
5 years, 8 months ago (2015-04-10 10:13:56 UTC) #2
tkent
lgtm
5 years, 8 months ago (2015-04-12 23:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076143002/1
5 years, 8 months ago (2015-04-13 01:04:34 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 02:44:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193609

Powered by Google App Engine
This is Rietveld 408576698