Make all of stdout/stderr/stdin pipes close-on-exec when spawing child processes.

runtime/bin/process_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include "bin/process.h"
 
 #include <crt_externs.h>  // NOLINT
@@ skipping 374 matching lines @@
     FDUtils::SetCloseOnExec(exec_control_[0]);
     FDUtils::SetCloseOnExec(exec_control_[1]);
 
     // For a detached process the pipe to connect stdout is still used for
     // signaling when to do the first fork.
     result = TEMP_FAILURE_RETRY(pipe(read_in_));
     if (result < 0) {
       return CleanupAndReturnError();
     }
     FDUtils::SetCloseOnExec(read_in_[0]);
+    FDUtils::SetCloseOnExec(read_in_[1]);
 
     // For detached processes the pipe to connect stderr and stdin are not used.
     if (mode_ != kDetached) {
       result = TEMP_FAILURE_RETRY(pipe(read_err_));
       if (result < 0) {
         return CleanupAndReturnError();
       }
       FDUtils::SetCloseOnExec(read_err_[0]);
+      FDUtils::SetCloseOnExec(read_err_[1]);
 
       result = TEMP_FAILURE_RETRY(pipe(write_out_));
       if (result < 0) {
         return CleanupAndReturnError();
       }
+      FDUtils::SetCloseOnExec(write_out_[0]);
       FDUtils::SetCloseOnExec(write_out_[1]);
     }
 
     return 0;
   }
 
 
   void NewProcess() {
     // Wait for parent process before setting up the child process.
     char msg;
@@ skipping 645 matching lines @@
     bzero(&act, sizeof(act));
     act.sa_handler = SIG_DFL;
     VOID_NO_RETRY_EXPECTED(sigaction(signal, &act, NULL));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)