Added method to host daemon to exchange an auth code for just an OAuth

remoting/host/setup/oauth_client.h

Index: remoting/host/setup/oauth_client.h
diff --git a/remoting/host/setup/oauth_client.h b/remoting/host/setup/oauth_client.h
index 5cc8f1f3bcfe099ac1e6cacb25db9dd7adbd7cba..79d1d9a9b5988ed73e80f53006f0584e7135648b 100644
--- a/remoting/host/setup/oauth_client.h
+++ b/remoting/host/setup/oauth_client.h
@@ -35,15 +35,17 @@ class OAuthClient : public gaia::GaiaOAuthClient::Delegate {
 
   ~OAuthClient() override;
 
-  // Redeems |auth_code| using |oauth_client_info| to obtain |refresh_token| and
-  // |access_token|, then uses the userinfo endpoint to obtain |user_email|.
-  // Calls CompletionCallback with |user_email| and |refresh_token| when done,
-  // or with empty strings on error.
-  // If a request is received while another one is  being processed, it is
-  // enqueued and processed after the first one is finished.
+  // Redeems |auth_code| using |oauth_client_info| to obtain
+  // |refresh_token| and |access_token|, then, if |need_user_email| is
+  // true, uses the userinfo endpoint to obtain |user_email|.  Calls
+  // CompletionCallback with |user_email| and |refresh_token| when
+  // done, or with empty strings on error.  If a request is received
+  // while another one is being processed, it is enqueued and
+  // processed after the first one is finished.
   void GetCredentialsFromAuthCode(

[Sergey Ulanov, 2015/04/22 21:55:40]

OAuthClient is just a wrapper for GaiaOAuthClient. in GaiaOAuthClient there are
two separate calls - one to get refresh token and another one to get e-mail. I
suggest separating these two functions here too. I.e. there can get
GetRefreshToken() and separate GetUserEmail() 

[John Williams, 2015/04/24 00:00:47]

I agree that would be cleaner, but I would rather not introduce a new method,
because modifying C++ code is a hassle, and once we switch over to using GCD,
there will be no need for it.  Eventually I plan to just rename this method and
remove the need_user_email parameter.

       const gaia::OAuthClientInfo& oauth_client_info,
       const std::string& auth_code,
+      bool need_user_email,
       CompletionCallback on_done);
 
   // gaia::GaiaOAuthClient::Delegate
@@ -61,10 +63,12 @@ class OAuthClient : public gaia::GaiaOAuthClient::Delegate {
   struct Request {
     Request(const gaia::OAuthClientInfo& oauth_client_info,
             const std::string& auth_code,
+            bool need_user_email,
             CompletionCallback on_done);
     virtual ~Request();
     gaia::OAuthClientInfo oauth_client_info;
     std::string auth_code;
+    bool need_user_email;
     CompletionCallback on_done;
   };
 
@@ -74,6 +78,7 @@ class OAuthClient : public gaia::GaiaOAuthClient::Delegate {
   std::queue<Request> pending_requests_;
   gaia::GaiaOAuthClient gaia_oauth_client_;
   std::string refresh_token_;
+  bool need_user_email_;
   CompletionCallback on_done_;
 
   DISALLOW_COPY_AND_ASSIGN(OAuthClient);