chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc - Issue 1076063002: Remove certificates from Channel ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

Issue 1076063002: Remove certificates from Channel ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Udpate KeysEqual to fail if preconditions fail Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('k') | chrome/browser/chromeos/login/profile_auth_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

diff --git a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

index dd20a8c8f28771828e0e0da93c99aa5409f1ea21..b219008ab61ce2292642a363d8d2a03835e2616a 100644

--- a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

+++ b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

@@ -30,9 +30,9 @@ void MockBrowsingDataChannelIDHelper::DeleteChannelID(

void MockBrowsingDataChannelIDHelper::AddChannelIDSample(

const std::string& server_id) {

ASSERT_TRUE(channel_ids_.find(server_id) == channel_ids_.end());

+ scoped_ptr<crypto::ECPrivateKey> key(crypto::ECPrivateKey::Create());

channel_id_list_.push_back(

- net::ChannelIDStore::ChannelID(

- server_id, base::Time(), base::Time(), "key", "cert"));

+ net::ChannelIDStore::ChannelID(server_id, base::Time(), key.Pass()));

channel_ids_[server_id] = true;

}