Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: net/socket/ssl_client_socket.cc

Issue 1076063002: Remove certificates from Channel ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket.cc
diff --git a/net/socket/ssl_client_socket.cc b/net/socket/ssl_client_socket.cc
index f333cb8ec89aaffe55d8f663a7b74e4ad100f119..41dd3b996cef3a4c3cb61c4fd981f95350d814c0 100644
--- a/net/socket/ssl_client_socket.cc
+++ b/net/socket/ssl_client_socket.cc
@@ -156,6 +156,7 @@ void SSLClientSocket::RecordChannelIDSupport(
CLIENT_ONLY = 1,
CLIENT_AND_SERVER = 2,
CLIENT_NO_ECC = 3,
+ // CLIENT_BAD_SYSTEM_TIME is unused now.
CLIENT_BAD_SYSTEM_TIME = 4,
CLIENT_NO_CHANNEL_ID_SERVICE = 5,
CHANNEL_ID_USAGE_MAX
@@ -167,8 +168,6 @@ void SSLClientSocket::RecordChannelIDSupport(
supported = CLIENT_NO_CHANNEL_ID_SERVICE;
else if (!supports_ecc)
supported = CLIENT_NO_ECC;
- else if (!channel_id_service->IsSystemTimeValid())
- supported = CLIENT_BAD_SYSTEM_TIME;
else
supported = CLIENT_ONLY;
}
@@ -190,11 +189,6 @@ bool SSLClientSocket::IsChannelIDEnabled(
DVLOG(1) << "Elliptic Curve not supported, not enabling channel ID.";
return false;
}
- if (!channel_id_service->IsSystemTimeValid()) {
- DVLOG(1) << "System time is not within the supported range for certificate "
- "generation, not enabling channel ID.";
- return false;
- }
return true;
}

Powered by Google App Engine
This is Rietveld 408576698