Remove certificates from Channel ID

net/test/channel_id_test_util.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_TEST_CHANNEL_ID_TEST_UTIL_H_
+#define NET_TEST_CHANNEL_ID_TEST_UTIL_H_
+
+#include <string>
+
+namespace crypto {
+class ECPrivateKey;
+}  // namespace crypto
+
+namespace net {
+
+void ExpectKeysEqual(crypto::ECPrivateKey* key1, crypto::ECPrivateKey* key2);
+void ExpectKeysNotEqual(crypto::ECPrivateKey* key1, crypto::ECPrivateKey* key2);

[Ryan Sleevi, 2015/05/18 23:54:35]

1) I think if we're going to go this route, it probably makes more sense to
return a ::testing::AssertionResult

2) Having this return void, instead of a bool, doesn't really engender good
usage. That is, callers have to know about GTest's rules about testing
subroutines.

3) Not terribly keen on a single-file test helper.

For example, why are these two functions and not just a single bool function?
Because failures could happen even when the keys are equal? How is that best
expressed.

[nharper, 2015/05/19 07:18:50]

I've updated this to combine these 2 methods into one method that returns a
::testing::AssertionResult. Given how testing::AssertionResult works in the
EXPECT_TRUE/FALSE macros, it makes more sense to return that instead of a bool
(and returning either a testing::AssertionResult or a bool makes more sense than
returning void).

It makes sense to move this into some sort of helper from individual
*_unittest.cc files, since it's now used by 5 separate test files. I put it in a
new file because I didn't see a file where it looked like it belonged, but if
there's a better place for it, I can move it elsewhere.

+
+}  // namespace net
+
+#endif  //  NET_TEST_CHANNEL_ID_TEST_UTIL_H_