Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1076033002: Disable BackgroundRendererProcesses in absence of Finch. (Closed)

Created:
5 years, 8 months ago by gab
Modified:
5 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable BackgroundRendererProcesses experiment in absence of Finch. (temporarily in order to get perf waterfall coverage for new session restore tests) BUG=459600 Committed: https://crrev.com/78011fcdf7c4e17949429bb99fbe6a68ca822b44 Cr-Commit-Position: refs/heads/master@{#324521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gab
Avi PTAL, please CQ if it LGTYs. Thanks, Gab
5 years, 8 months ago (2015-04-09 20:19:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076033002/1
5 years, 8 months ago (2015-04-09 20:21:02 UTC) #4
Avi (use Gerrit)
lgtm
5 years, 8 months ago (2015-04-09 20:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076033002/1
5 years, 8 months ago (2015-04-09 21:07:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 22:10:15 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78011fcdf7c4e17949429bb99fbe6a68ca822b44 Cr-Commit-Position: refs/heads/master@{#324521}
5 years, 8 months ago (2015-04-09 22:11:10 UTC) #10
gab
5 years, 8 months ago (2015-04-13 12:45:15 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1083673002/ by gab@chromium.org.

The reason for reverting is: Bring BackgroundRendererProcesses back on trunk --
will give us perf waterfall coverage now (session_restore tests were borked when
this landed so we didn't get the backward effect and are still in the dark
here)....

Powered by Google App Engine
This is Rietveld 408576698