Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/media/android/browser_demuxer_android.cc

Issue 1076013002: Added stub MediaSourcePlayer for developing behind the flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN build Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_demuxer_android.cc
diff --git a/content/browser/media/android/browser_demuxer_android.cc b/content/browser/media/android/browser_demuxer_android.cc
index ed462032fdd7f6ad3d278996d36ae4009370ecca..ddaca7efa3cedbe025f748914a01b633141d1621 100644
--- a/content/browser/media/android/browser_demuxer_android.cc
+++ b/content/browser/media/android/browser_demuxer_android.cc
@@ -4,7 +4,10 @@
#include "content/browser/media/android/browser_demuxer_android.h"
+#include "base/command_line.h"
#include "content/common/media/media_player_messages_android.h"
+#include "media/base/android/media_codec_player.h"
+#include "media/base/media_switches.h"
namespace content {
@@ -52,21 +55,32 @@ class BrowserDemuxerAndroid::Internal : public media::DemuxerAndroid {
};
BrowserDemuxerAndroid::BrowserDemuxerAndroid()
- : BrowserMessageFilter(MediaPlayerMsgStart) {}
+ : BrowserMessageFilter(MediaPlayerMsgStart) {
+ bool enable_media_thread =
+ base::CommandLine::ForCurrentProcess()->
+ HasSwitch(switches::kEnableMediaThreadForMediaPlayback);
+
+ task_runner_ =
+ enable_media_thread ?
+ media::GetMediaTaskRunner().get() :
timav 2015/05/08 22:32:01 Without the BUILD.gn change in content the linker
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI).get();
+
+}
BrowserDemuxerAndroid::~BrowserDemuxerAndroid() {}
-void BrowserDemuxerAndroid::OverrideThreadForMessage(
- const IPC::Message& message,
- BrowserThread::ID* thread) {
+base::TaskRunner* BrowserDemuxerAndroid::OverrideTaskRunnerForMessage(
+ const IPC::Message& message) {
+
switch (message.type()) {
case MediaPlayerHostMsg_DemuxerReady::ID:
case MediaPlayerHostMsg_ReadFromDemuxerAck::ID:
case MediaPlayerHostMsg_DurationChanged::ID:
case MediaPlayerHostMsg_DemuxerSeekDone::ID:
- *thread = BrowserThread::UI;
- return;
+ return task_runner_;
}
+
+ return nullptr;
}
bool BrowserDemuxerAndroid::OnMessageReceived(const IPC::Message& message) {
@@ -95,29 +109,46 @@ void BrowserDemuxerAndroid::AddDemuxerClient(
media::DemuxerAndroidClient* client) {
DVLOG(1) << __FUNCTION__ << " peer_pid=" << peer_pid()
<< " demuxer_client_id=" << demuxer_client_id;
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
demuxer_clients_.AddWithID(client, demuxer_client_id);
+
+ if (pending_configs_.count(demuxer_client_id)) {
+ client->OnDemuxerConfigsAvailable(pending_configs_[demuxer_client_id]);
+ pending_configs_.erase(demuxer_client_id);
+ }
}
void BrowserDemuxerAndroid::RemoveDemuxerClient(int demuxer_client_id) {
DVLOG(1) << __FUNCTION__ << " peer_pid=" << peer_pid()
<< " demuxer_client_id=" << demuxer_client_id;
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
demuxer_clients_.Remove(demuxer_client_id);
}
void BrowserDemuxerAndroid::OnDemuxerReady(
int demuxer_client_id,
const media::DemuxerConfigs& configs) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
media::DemuxerAndroidClient* client =
demuxer_clients_.Lookup(demuxer_client_id);
+
if (client)
client->OnDemuxerConfigsAvailable(configs);
+ else
+ pending_configs_[demuxer_client_id] = configs;
}
void BrowserDemuxerAndroid::OnReadFromDemuxerAck(
int demuxer_client_id,
const media::DemuxerData& data) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
media::DemuxerAndroidClient* client =
demuxer_clients_.Lookup(demuxer_client_id);
+
if (client)
client->OnDemuxerDataAvailable(data);
}
@@ -125,18 +156,26 @@ void BrowserDemuxerAndroid::OnReadFromDemuxerAck(
void BrowserDemuxerAndroid::OnDemuxerSeekDone(
int demuxer_client_id,
const base::TimeDelta& actual_browser_seek_time) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
media::DemuxerAndroidClient* client =
demuxer_clients_.Lookup(demuxer_client_id);
+
if (client)
client->OnDemuxerSeekDone(actual_browser_seek_time);
}
void BrowserDemuxerAndroid::OnDurationChanged(int demuxer_client_id,
const base::TimeDelta& duration) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+
media::DemuxerAndroidClient* client =
demuxer_clients_.Lookup(demuxer_client_id);
+
if (client)
client->OnDemuxerDurationChanged(duration);
+ else
+ pending_configs_[demuxer_client_id].duration = duration;
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698