Issue 1075993003: [sql] Also call ShouldIgnoreSqliteError() in Release build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1075993003: [sql] Also call ShouldIgnoreSqliteError() in Release build. (Closed)

Created:
5 years, 8 months ago by Scott Hess - ex-Googler

Modified:
5 years, 8 months ago

Reviewers:
maniscalco

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[sql] Also call ShouldIgnoreSqliteError() in Release build. https://crrev.com/92a2ab1f1d0cdff39e6d506c4cb6a80038baeeb3 put the test (which has a side effect) in DLOG_IF which doesn't apply in Release builds. BUG=none Committed: https://crrev.com/193bfb62b066894a13b56c8bc780571af4a5b59e Cr-Commit-Position: refs/heads/master@{#324697}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	sql/connection.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075993003/1

5 years, 8 months ago (2015-04-10 20:43:49 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-10 22:31:07 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/193bfb62b066894a13b56c8bc780571af4a5b59e
Cr-Commit-Position: refs/heads/master@{#324697}