Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations

Add basic crankshaft support for slow-mode for-in to avoid disabling optimizations

BUG=

Committed: https://crrev.com/8c98cc074ef8278ce1c4dcd4790e8aaf6fbeedc6
Cr-Commit-Position: refs/heads/master@{#27748}

[Toon Verwaest, 2015-04-10 09:59:09]

verwaest@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Toon Verwaest, 2015-04-10 09:59:10]

PTAL

[mvstanton, 2015-04-10 11:40:07]

LGTM, one nit. Very nice :).

https://codereview.chromium.org/1075933003/diff/60001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1075933003/diff/60001/src/hydrogen.cc#newcode...
src/hydrogen.cc:5109: enumerable = environment()->ExpressionStackAt(4);
nit: why do you need to get enumerable again? Add a comment about that.

[Toon Verwaest, 2015-04-10 11:47:50]

Added comment.

[Toon Verwaest, 2015-04-10 11:47:55]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-04-10 11:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1075933003/#ps80001
(title: "Added comment")

[commit-bot: I haz the power, 2015-04-10 11:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075933003/80001

[Toon Verwaest, 2015-04-10 12:07:55]

verwaest@chromium.org changed reviewers:
+ jarin@chromium.org

[Toon Verwaest, 2015-04-10 12:07:56]

Disabled new test on turbo-fan since deopt points are missing.

[Toon Verwaest, 2015-04-10 12:08:01]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-04-10 12:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1075933003/#ps100001
(title: "Disable for-in-opt for turbofan")

[commit-bot: I haz the power, 2015-04-10 12:08:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075933003/100001

[commit-bot: I haz the power, 2015-04-10 13:15:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-10 13:15:50]

Patchset 6 (id:??) landed as
https://crrev.com/8c98cc074ef8278ce1c4dcd4790e8aaf6fbeedc6
Cr-Commit-Position: refs/heads/master@{#27748}

[adamk, 2015-04-15 21:03:37]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2015-04-15 21:03:38]

This caused failures in a dromaeo benchmark (not perf failures, actual logic
changes); see http://crbug.com/476592. I'm reverting in
https://codereview.chromium.org/1066663005/

[Michael Starzinger, 2015-04-15 21:13:33]

In the unlikely case that this is not being relanded, please let me know,
because I would like to at least reland the test-case as it was covering a
bailout point in TurboFan as well.