Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 1075863003: Fix example about java_binary to java_binary instead of java_library (Closed)

Created:
5 years, 8 months ago by jkarp
Modified:
5 years, 8 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix example about java_binary to java_binary instead of java_library Change the example provided in rules.gni for declaring a java executable target to java_binary instead of java_library. BUG=476112 Committed: https://crrev.com/8c8162e4c9d3cc2310cc290b10b8d509f876b607 Cr-Commit-Position: refs/heads/master@{#324932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarp
Hello, PTAL! Thanks.
5 years, 8 months ago (2015-04-10 22:03:17 UTC) #2
cjhopman
lgtm
5 years, 8 months ago (2015-04-13 21:14:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075863003/1
5 years, 8 months ago (2015-04-13 21:29:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 23:01:13 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 23:02:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c8162e4c9d3cc2310cc290b10b8d509f876b607
Cr-Commit-Position: refs/heads/master@{#324932}

Powered by Google App Engine
This is Rietveld 408576698