Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 1075833002: Delay completion of getUserMedia in UserMediaClient (Closed)

Created:
4 years, 1 month ago by perkj_chrome
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This fixes a problem when the RenderFrame is destroyed within the context of a getusermedia callback. BUG=472617, 474370 TBR=tommi@chromium.org Committed: https://crrev.com/fa7c6fd4aa278dab68c5987b45353e064ce8e0ad Cr-Commit-Position: refs/heads/master@{#324434}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -33 lines) Patch
M content/renderer/media/user_media_client_impl.h View 1 chunk +10 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 4 chunks +50 lines, -29 lines 0 comments Download
M content/renderer/media/user_media_client_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
Please?
4 years, 1 month ago (2015-04-09 12:54:52 UTC) #3
magjed_chromium
lgtm
4 years, 1 month ago (2015-04-09 14:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075833002/20001
4 years, 1 month ago (2015-04-09 14:29:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2015-04-09 14:33:28 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2015-04-09 14:34:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa7c6fd4aa278dab68c5987b45353e064ce8e0ad
Cr-Commit-Position: refs/heads/master@{#324434}

Powered by Google App Engine
This is Rietveld 408576698