build/android/pylib/gtest/gtest_test_instance.py - Issue 1075783002: Enable components_browsertests on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/gtest_test_instance.py

Issue 1075783002: Enable components_browsertests on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build and add java dependency to components/test/DEPS Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/gtest/gtest_test_instance.py

diff --git a/build/android/pylib/gtest/gtest_test_instance.py b/build/android/pylib/gtest/gtest_test_instance.py

index 186b8fcf4c9739cbfa2e4541ef1c6e77d571fcfa..b6f83b31b2e97637c55036da84b6c9b28f6f5d28 100644

--- a/build/android/pylib/gtest/gtest_test_instance.py

+++ b/build/android/pylib/gtest/gtest_test_instance.py

@@ -92,9 +92,10 @@ class GtestTestInstance(test_instance.TestInstance):

raise ValueError('Platform mode currently supports only 1 gtest suite')

self._suite = args.suite_name[0]

- if self._suite == 'content_browsertests':

- error_func('content_browsertests are not currently supported '

- 'in platform mode.')

+ if (self._suite == 'content_browsertests' or

+ self._suite == 'components_browsertests'):

+ error_func('%s are not currently supported '

+ 'in platform mode.' % self._suite)

self._apk_path = os.path.join(

constants.GetOutDirectory(), 'apks', '%s.apk' % self._suite)

else: