Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1075773003: Wrap proxy.js in a function. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap proxy.js in a function. Committed: https://crrev.com/7667d19eecd44299f366c987462b6e23e2c217e3 Cr-Commit-Position: refs/heads/master@{#27746}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -34 lines) Patch
M src/bootstrapper.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/proxy.js View 1 3 chunks +33 lines, -23 lines 2 comments Download
M src/v8natives.js View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 8 months ago (2015-04-10 10:57:18 UTC) #2
rossberg
Yay for using the module pattern, just one comment. https://codereview.chromium.org/1075773003/diff/20001/src/proxy.js File src/proxy.js (right): https://codereview.chromium.org/1075773003/diff/20001/src/proxy.js#newcode15 src/proxy.js:15: ...
5 years, 8 months ago (2015-04-10 11:00:28 UTC) #4
Yang
https://codereview.chromium.org/1075773003/diff/20001/src/proxy.js File src/proxy.js (right): https://codereview.chromium.org/1075773003/diff/20001/src/proxy.js#newcode15 src/proxy.js:15: "use strict"; On 2015/04/10 11:00:28, rossberg wrote: > DBC: ...
5 years, 8 months ago (2015-04-10 11:05:11 UTC) #5
mvstanton
lgtm
5 years, 8 months ago (2015-04-10 11:45:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075773003/20001
5 years, 8 months ago (2015-04-10 12:02:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 12:32:24 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 12:32:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7667d19eecd44299f366c987462b6e23e2c217e3
Cr-Commit-Position: refs/heads/master@{#27746}

Powered by Google App Engine
This is Rietveld 408576698