Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: gcl.py

Issue 1075723002: Extract authentication options handling into a separate function. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « commit_queue.py ('k') | git_cherry_pick_upload.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index cf657893c737133e5266ad8ff27bb052295f2ee0..16f4f282735f2f32792775963c1ad88894ee53c1 100755
--- a/gcl.py
+++ b/gcl.py
@@ -23,6 +23,7 @@ import urllib2
import breakpad # pylint: disable=W0611
+import auth
import fix_encoding
import gclient_utils
import git_cl
@@ -351,7 +352,10 @@ class ChangeInfo(object):
if not self._rpc_server:
if not self.rietveld:
ErrorExit(CODEREVIEW_SETTINGS_FILE_NOT_FOUND)
- self._rpc_server = rietveld.CachingRietveld(self.rietveld, None, None)
+ # TODO(vadimsh): glc.py should be deleted soon. Do not bother much about
+ # authentication options and always use defaults.
+ self._rpc_server = rietveld.CachingRietveld(
+ self.rietveld, auth.make_auth_config())
return self._rpc_server
def CloseIssue(self):
@@ -1465,6 +1469,10 @@ def main(argv):
'\nYour python version %s is unsupported, please upgrade.\n' %
sys.version.split(' ', 1)[0])
return 2
+
+ sys.stderr.write('Warning: gcl is going away soon. Get off subversion!\n')
+ sys.stderr.write('See http://crbug.com/475321 for more details.\n')
+
if not argv:
argv = ['help']
command = Command(argv[0])
« no previous file with comments | « commit_queue.py ('k') | git_cherry_pick_upload.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698