Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1075723002: Extract authentication options handling into a separate function. (Closed)

Created:
5 years, 8 months ago by Vadim Sh.
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Extract authentication options handling into a separate function. It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294746

Patch Set 1 #

Total comments: 14

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -187 lines) Patch
M apply_issue.py View 1 8 chunks +18 lines, -33 lines 0 comments Download
A auth.py View 1 chunk +99 lines, -0 lines 0 comments Download
M commit_queue.py View 3 chunks +4 lines, -1 line 0 comments Download
M gcl.py View 1 3 chunks +9 lines, -1 line 0 comments Download
M git_cherry_pick_upload.py View 3 chunks +20 lines, -15 lines 0 comments Download
M git_cl.py View 31 chunks +81 lines, -37 lines 0 comments Download
M my_activity.py View 4 chunks +7 lines, -1 line 0 comments Download
M my_reviews.py View 5 chunks +13 lines, -6 lines 0 comments Download
M presubmit_support.py View 5 chunks +5 lines, -6 lines 0 comments Download
M rietveld.py View 1 chunk +3 lines, -20 lines 0 comments Download
M tests/gcl_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/git_cl_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/rietveld_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/upload.py View 5 chunks +29 lines, -63 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vadim Sh.
https://codereview.chromium.org/1075723002/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1075723002/diff/1/apply_issue.py#newcode150 apply_issue.py:150: if options.no_auth: I do not fully understand this logic... ...
5 years, 8 months ago (2015-04-09 01:04:39 UTC) #1
M-A Ruel
lgtm, good luck. https://codereview.chromium.org/1075723002/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1075723002/diff/1/apply_issue.py#newcode161 apply_issue.py:161: except rietveld.upload.ClientLoginError, e: except rietveld.upload.ClientLoginError as ...
5 years, 8 months ago (2015-04-09 01:20:59 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1075723002/diff/1/apply_issue.py File apply_issue.py (right): https://codereview.chromium.org/1075723002/diff/1/apply_issue.py#newcode161 apply_issue.py:161: except rietveld.upload.ClientLoginError, e: On 2015/04/09 01:20:59, M-A Ruel wrote: ...
5 years, 8 months ago (2015-04-09 01:34:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075723002/20001
5 years, 8 months ago (2015-04-09 21:39:29 UTC) #6
commit-bot: I haz the power
Failed to apply patch for depot_tools/auth.py: While running svn add depot_tools/auth.py --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
5 years, 8 months ago (2015-04-09 21:39:38 UTC) #8
Vadim Sh.
5 years, 8 months ago (2015-04-09 22:02:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 294746.

Powered by Google App Engine
This is Rietveld 408576698