Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1075643002: Add windows-specific result files for form_combobox_num/per tests. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add windows-specific result files for form_combobox_num/per tests. The output from these clever tests depends upon the platform-specific behaviour of fcvt() when more significant digits are requested than there is precision in a double type. TBR=thestig@chromium.org Committed: e733fe1d98fad50c9b5f4023f08db429143b1291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A fx/new/form/form_combobox_num_expected_win.pdf.0.png View Binary file 0 comments Download
A fx/new/form/form_combobox_per_expected_win.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 8 (1 generated)
Tom Sepez
TBD'd. We'll use these in a follow-up CL to enable per-platform expected results files.
5 years, 8 months ago (2015-04-08 21:53:30 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as e733fe1d98fad50c9b5f4023f08db429143b1291 (presubmit successful).
5 years, 8 months ago (2015-04-08 22:22:41 UTC) #3
Tom Sepez
+Bruce (you'll enjoy this one)
5 years, 8 months ago (2015-04-09 16:33:01 UTC) #4
brucedawson
Uggh. And in addition to the differences in printing doubles there is also the risk ...
5 years, 8 months ago (2015-04-09 16:49:16 UTC) #5
Lei Zhang
lgtm Should we file a bug for this platform inconsistency and fix it at some ...
5 years, 8 months ago (2015-04-09 19:29:03 UTC) #6
Tom Sepez
On 2015/04/09 19:29:03, Lei Zhang wrote: > lgtm > > Should we file a bug ...
5 years, 8 months ago (2015-04-09 19:33:15 UTC) #7
Lei Zhang
5 years, 8 months ago (2015-04-22 00:53:51 UTC) #8
Message was sent while issue was closed.
BTW, this got committed with the author as "unknown <tsepez@chromium.org>"

Powered by Google App Engine
This is Rietveld 408576698