Initialize observer_ to nullptr in DevicePermissionsDialogView.

chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc

Index: chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
diff --git a/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc b/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
index a4acefe0e323ba2cd245a165363cbca88b88caad..9443cee949ae347e3b110bc4895444489164042d 100644
--- a/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
+++ b/chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc
@@ -44,7 +44,7 @@ class DevicePermissionsTableModel
 
  private:
   scoped_refptr<DevicePermissionsPrompt::Prompt> prompt_;
-  ui::TableModelObserver* observer_;
+  ui::TableModelObserver* observer_ = nullptr;

[benwells, 2015/04/08 22:53:22]

since you already have an initializer list in the constructor, why not do it
there, the old fashioned way?

[Reilly Grant (use Gerrit), 2015/04/08 22:57:25]

This method guarantees that any future constructor will also inherit this
default behavior. Disregarding the initializer list in the constructor this
feels equivalent to the way that the scoped_refptr above would be initialized to
nullptr because that's what its default constructor does. This is simply working
around the lack of a default constructor for raw pointer types.

[benwells, 2015/04/08 23:44:29]

Yes, I understand that this will be caught by all future constructors.

Can you see that it might be confusing for people reading the code?

[Reilly Grant (use Gerrit), 2015/04/09 00:06:35]

I disagree that this is confusing. This method is clearer than constructor
initialization lists because one can tell from reading only the field
declarations that they will all be initialized without having to check that the
(possibly multiple) constructors aren't missing something.

From personal experience I am very likely to shoot myself in the foot by adding
a primitive type field to a class and forgetting to add an initializer to the
constructor. Combining these two in one place seems like a net win.

 };
 
 int DevicePermissionsTableModel::RowCount() {