Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1075563002: Use a base::LinkedList rather than a std::deque to back CertNetFetcherImpl's request list. (Closed)

Created:
5 years, 8 months ago by eroman
Modified:
5 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert_fetcher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a base::LinkedList rather than a std::deque to back CertNetFetcherImpl's request list. This has the advantage of making cancellation of requests an O(1) operation rather than O(NumRequestsPerJob). BUG=455366 Committed: https://crrev.com/9afe19122a83f762baded7003b25ff22205fd533 Cr-Commit-Position: refs/heads/master@{#324336}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M net/cert_net/cert_net_fetcher_impl.cc View 6 chunks +19 lines, -16 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 8 months ago (2015-04-08 18:25:31 UTC) #2
davidben
lgtm https://codereview.chromium.org/1075563002/diff/20001/net/cert_net/cert_net_fetcher_impl.cc File net/cert_net/cert_net_fetcher_impl.cc (right): https://codereview.chromium.org/1075563002/diff/20001/net/cert_net/cert_net_fetcher_impl.cc#newcode77 net/cert_net/cert_net_fetcher_impl.cc:77: public base::LinkNode<RequestImpl> { Huh, I didn't know that ...
5 years, 8 months ago (2015-04-08 22:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075563002/20001
5 years, 8 months ago (2015-04-08 22:49:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 01:49:14 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 01:50:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9afe19122a83f762baded7003b25ff22205fd533
Cr-Commit-Position: refs/heads/master@{#324336}

Powered by Google App Engine
This is Rietveld 408576698