Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1075543002: Rename the distance field geoprocs to something more reasonable. (Closed)

Created:
5 years, 8 months ago by jvanverth1
Modified:
5 years, 8 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename the distance field geoprocs to something more reasonable. Prep for adding Mali fix for distance field paths. BUG=skia:3528 Committed: https://skia.googlesource.com/skia/+/502286d7b8ecf26a3a33e8098335034e21e4b082

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix line wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -147 lines) Patch
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 10 chunks +27 lines, -27 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 27 chunks +91 lines, -101 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jvanverth1
I'll rename the files themselves in a separate change.
5 years, 8 months ago (2015-04-08 18:02:34 UTC) #2
joshualitt
lgtm + nit https://codereview.chromium.org/1075543002/diff/1/src/gpu/effects/GrDistanceFieldTextureEffect.cpp File src/gpu/effects/GrDistanceFieldTextureEffect.cpp (right): https://codereview.chromium.org/1075543002/diff/1/src/gpu/effects/GrDistanceFieldTextureEffect.cpp#newcode41 src/gpu/effects/GrDistanceFieldTextureEffect.cpp:41: const GrDistanceFieldA8TextGeoProc& dfTexEffect = args.fGP.cast<GrDistanceFieldA8TextGeoProc>(); Line ...
5 years, 8 months ago (2015-04-08 18:20:51 UTC) #3
jvanverth1
https://codereview.chromium.org/1075543002/diff/1/src/gpu/effects/GrDistanceFieldTextureEffect.cpp File src/gpu/effects/GrDistanceFieldTextureEffect.cpp (right): https://codereview.chromium.org/1075543002/diff/1/src/gpu/effects/GrDistanceFieldTextureEffect.cpp#newcode41 src/gpu/effects/GrDistanceFieldTextureEffect.cpp:41: const GrDistanceFieldA8TextGeoProc& dfTexEffect = args.fGP.cast<GrDistanceFieldA8TextGeoProc>(); On 2015/04/08 18:20:51, joshualitt ...
5 years, 8 months ago (2015-04-08 18:45:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075543002/20001
5 years, 8 months ago (2015-04-08 18:48:28 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:37:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/502286d7b8ecf26a3a33e8098335034e21e4b082

Powered by Google App Engine
This is Rietveld 408576698