cc: Add UMA stats for record and raster time.

cc/resources/display_list_recording_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/display_list_recording_source.h"
 
 #include <algorithm>
 
+#include "cc/base/histograms.h"
 #include "cc/base/region.h"
 #include "cc/layers/content_layer_client.h"
 #include "cc/resources/display_item_list.h"
 #include "cc/resources/display_list_raster_source.h"
 #include "skia/ext/analysis_canvas.h"
 
 namespace {
 
 // Layout pixel buffer around the visible layer rect to record.  Any base
 // picture that intersects the visible layer rect expanded by this distance
 // will be recorded.
 const int kPixelDistanceToRecord = 8000;
 // We don't perform solid color analysis on images that have more than 10 skia
 // operations.
 const int kOpCountThatIsOkToAnalyze = 10;
 
+DEFINE_SCOPED_UMA_HISTOGRAM_AREA_TIMER(
+    ScopedDisplayListRecordingSourceUpdateTimer,
+    "Renderer4.DisplayListRecordingSourceRecordUs",
+    "Renderer4.DisplayListRecordingSourceRecordedAreaPerMs");
+
 }  // namespace
 
 namespace cc {
 
 DisplayListRecordingSource::DisplayListRecordingSource(
     const gfx::Size& grid_cell_size)
     : slow_down_raster_scale_factor_for_debug_(0),
       gather_pixel_refs_(false),
       requires_clear_(false),
       is_solid_color_(false),
       solid_color_(SK_ColorTRANSPARENT),
       background_color_(SK_ColorTRANSPARENT),
       pixel_record_distance_(kPixelDistanceToRecord),
       grid_cell_size_(grid_cell_size),
       is_suitable_for_gpu_rasterization_(true) {
 }
 
 DisplayListRecordingSource::~DisplayListRecordingSource() {
 }
 
 bool DisplayListRecordingSource::UpdateAndExpandInvalidation(
     ContentLayerClient* painter,
     Region* invalidation,
     const gfx::Size& layer_size,
     const gfx::Rect& visible_layer_rect,
     int frame_number,
     RecordingMode recording_mode) {
+  ScopedDisplayListRecordingSourceUpdateTimer timer;
   bool updated = false;
 
   if (size_ != layer_size) {
     size_ = layer_size;
     updated = true;
   }
 
   gfx::Rect old_recorded_viewport = recorded_viewport_;
   recorded_viewport_ = visible_layer_rect;
   recorded_viewport_.Inset(-pixel_record_distance_, -pixel_record_distance_);
   recorded_viewport_.Intersect(gfx::Rect(GetSize()));
 
   if (recorded_viewport_ != old_recorded_viewport) {
     // Invalidate newly-exposed and no-longer-exposed areas.
     Region newly_exposed_region(recorded_viewport_);
     newly_exposed_region.Subtract(old_recorded_viewport);
     invalidation->Union(newly_exposed_region);
 
     Region no_longer_exposed_region(old_recorded_viewport);
     no_longer_exposed_region.Subtract(recorded_viewport_);
     invalidation->Union(no_longer_exposed_region);
 
     updated = true;
   }
 
+  // Count the area that is being invalidated.
+  for (Region::Iterator it(*invalidation); it.has_rect(); it.next())

[enne (OOO), 2015/04/13 21:52:26]

This is a petty nit, but it's weird to have this inside the timer.  I think you
could get away with the timer having area as a ctor arg and no Set/Add area
calls.

[jbroman, 2015/04/14 14:44:36]

Prevents the work before the invalidation is available (e.g. in
PicturePile::ApplyInvalidationAndResize) from being counted in the time. (Less
of a big deal now that the invalidation rects, which are available earlier, are
being used.)

Happy to make this change if that tradeoff sgty.

[enne (OOO), 2015/04/14 16:54:10]

Hmm, ok, this is fine.  I am not sure whether it makes sense to include the
synthetic invalidations here, but I think that's ok.  I suspect the display
lists are going to need the same synthetic invalidations for resizing anyway, so
maybe it'll balanceo ut.

+    timer.AddArea(it.rect().size().GetArea());
+
   if (!updated && !invalidation->Intersects(recorded_viewport_))
     return false;
 
   ContentLayerClient::PaintingControlSetting painting_control =
       ContentLayerClient::PAINTING_BEHAVIOR_NORMAL;
 
   switch (recording_mode) {
     case RECORD_NORMALLY:
       // Already setup for normal recording.
       break;
@@ skipping 94 matching lines @@
   is_solid_color_ = canvas.GetColorIfSolid(&solid_color_);
 }
 
 void DisplayListRecordingSource::Clear() {
   recorded_viewport_ = gfx::Rect();
   display_list_ = NULL;
   is_solid_color_ = false;
 }
 
 }  // namespace cc