Chromium Code Reviews| Index: components/cronet/histogram_manager_unittest.cc |
| diff --git a/components/metrics/histogram_manager_unittest.cc b/components/cronet/histogram_manager_unittest.cc |
| similarity index 84% |
| rename from components/metrics/histogram_manager_unittest.cc |
| rename to components/cronet/histogram_manager_unittest.cc |
| index 5e5f99261b9dbcbcfc8d6cd660d8de3909fb78c4..cee09c7f2ab38dd6398acf68eca8db466de81a21 100644 |
| --- a/components/metrics/histogram_manager_unittest.cc |
| +++ b/components/cronet/histogram_manager_unittest.cc |
| @@ -2,19 +2,22 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#include "components/metrics/histogram_manager.h" |
| +#include "components/cronet/histogram_manager.h" |
| #include <string> |
| #include "base/basictypes.h" |
| +#include "base/metrics/statistics_recorder.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| -namespace metrics { |
| +namespace cronet { |
| + |
| +using metrics::ChromeUserMetricsExtension; |
| +using metrics::HistogramEventProto; |
| -// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.* |
| -// files into components/android/cronet. |
| // TODO(rtenneti): enable flaky HistogramBucketFields unit test. |
| -TEST(HistogramManager, DISABLED_HistogramBucketFields) { |
| +TEST(HistogramManager, HistogramBucketFields) { |
| + base::StatisticsRecorder::Initialize(); |
| // Capture histograms at the start of the test to avoid later GetDeltas() |
| // calls picking them up. |
| std::vector<uint8> data_init; |
| @@ -42,7 +45,7 @@ TEST(HistogramManager, DISABLED_HistogramBucketFields) { |
| std::vector<uint8> data2; |
| EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data2)); |
| EXPECT_FALSE(data2.empty()); |
| - ChromeUserMetricsExtension uma_proto2; |
| + metrics::ChromeUserMetricsExtension uma_proto2; |
|
xunjieli
2015/04/08 21:30:51
nit: You already have "using" for this on line 15.
mef
2015/04/08 21:41:21
Oops, I've started adding those, but decided to go
|
| EXPECT_TRUE(uma_proto2.ParseFromArray( |
| reinterpret_cast<const char*>(&data2[0]), data2.size())); |
| EXPECT_FALSE(data2.empty()); |
| @@ -55,4 +58,4 @@ TEST(HistogramManager, DISABLED_HistogramBucketFields) { |
| EXPECT_EQ(1, histogram_proto2.bucket(0).count()); |
| } |
| -} // namespace metrics |
| +} // namespace cronet |