Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: components/cronet/histogram_manager_unittest.cc

Issue 1075503002: Move histogram_manager from components/metrics to components/cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make cronet dependency specific to Android. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/histogram_manager.cc ('k') | components/metrics.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/histogram_manager_unittest.cc
diff --git a/components/metrics/histogram_manager_unittest.cc b/components/cronet/histogram_manager_unittest.cc
similarity index 92%
rename from components/metrics/histogram_manager_unittest.cc
rename to components/cronet/histogram_manager_unittest.cc
index 5e5f99261b9dbcbcfc8d6cd660d8de3909fb78c4..bb0eff892b82572534b97abf59764ffdca2502d1 100644
--- a/components/metrics/histogram_manager_unittest.cc
+++ b/components/cronet/histogram_manager_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/metrics/histogram_manager.h"
+#include "components/cronet/histogram_manager.h"
#include <string>
@@ -11,8 +11,6 @@
namespace metrics {
-// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.*
-// files into components/android/cronet.
// TODO(rtenneti): enable flaky HistogramBucketFields unit test.
TEST(HistogramManager, DISABLED_HistogramBucketFields) {
Alexei Svitkine (slow) 2015/04/08 17:56:37 Any idea why this is still disabled/flaky? Are you
mef 2015/04/08 18:06:04 Good question, I probably should, although I'm not
ramant (doing other things) 2015/04/08 18:22:13 I don't remember. Is it possible try LOCAL_HISTOGR
// Capture histograms at the start of the test to avoid later GetDeltas()
« no previous file with comments | « components/cronet/histogram_manager.cc ('k') | components/metrics.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698