Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: components/cronet/histogram_manager.h

Issue 1075503002: Move histogram_manager from components/metrics to components/cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Raman's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/cronet_static.gypi ('k') | components/cronet/histogram_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/histogram_manager.h
diff --git a/components/metrics/histogram_manager.h b/components/cronet/histogram_manager.h
similarity index 77%
rename from components/metrics/histogram_manager.h
rename to components/cronet/histogram_manager.h
index 7334ae35f29a0305efdb6fc5d85b3288fdbd73fa..ae4b249cc43ad69cfee23406f2c04a7f270c2dd7 100644
--- a/components/metrics/histogram_manager.h
+++ b/components/cronet/histogram_manager.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
-#define COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
+#ifndef COMPONENTS_CRONET_HISTOGRAM_MANAGER_H_
+#define COMPONENTS_CRONET_HISTOGRAM_MANAGER_H_
#include <string>
#include <vector>
@@ -16,14 +16,11 @@
#include "base/metrics/histogram_snapshot_manager.h"
#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
-namespace metrics {
+namespace cronet {
-// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.*
-// files into components/android/cronet.
-//
-// A HistogramManager instance is created by Android. It is the central
-// controller for the acquisition of log data, and the automatic transmission of
-// that log data to an external server.
+// A HistogramManager instance is created by the app. It is the central
+// controller for the acquisition of log data, and recording deltas for
+// transmission to an external server.
class HistogramManager : public base::HistogramFlattener {
public:
HistogramManager();
@@ -57,6 +54,6 @@ class HistogramManager : public base::HistogramFlattener {
DISALLOW_COPY_AND_ASSIGN(HistogramManager);
};
-} // namespace metrics
+} // namespace cronet
-#endif // COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
+#endif // COMPONENTS_CRONET_HISTOGRAM_MANAGER_H_
« no previous file with comments | « components/cronet/cronet_static.gypi ('k') | components/cronet/histogram_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698