Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: components/metrics/histogram_manager_unittest.cc

Issue 1075503002: Move histogram_manager from components/metrics to components/cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Raman's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/histogram_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/histogram_manager_unittest.cc
diff --git a/components/metrics/histogram_manager_unittest.cc b/components/metrics/histogram_manager_unittest.cc
deleted file mode 100644
index 5e5f99261b9dbcbcfc8d6cd660d8de3909fb78c4..0000000000000000000000000000000000000000
--- a/components/metrics/histogram_manager_unittest.cc
+++ /dev/null
@@ -1,58 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/metrics/histogram_manager.h"
-
-#include <string>
-
-#include "base/basictypes.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace metrics {
-
-// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.*
-// files into components/android/cronet.
-// TODO(rtenneti): enable flaky HistogramBucketFields unit test.
-TEST(HistogramManager, DISABLED_HistogramBucketFields) {
- // Capture histograms at the start of the test to avoid later GetDeltas()
- // calls picking them up.
- std::vector<uint8> data_init;
- HistogramManager::GetInstance()->GetDeltas(&data_init);
-
- // kNoFlags filter should record all histograms.
- UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager", 1, 2);
-
- std::vector<uint8> data;
- EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data));
- EXPECT_FALSE(data.empty());
- ChromeUserMetricsExtension uma_proto;
- EXPECT_TRUE(uma_proto.ParseFromArray(
- reinterpret_cast<const char*>(&data[0]), data.size()));
- EXPECT_FALSE(data.empty());
-
- const HistogramEventProto& histogram_proto =
- uma_proto.histogram_event(uma_proto.histogram_event_size() - 1);
- ASSERT_EQ(1, histogram_proto.bucket_size());
- EXPECT_LE(0, histogram_proto.bucket(0).min());
- EXPECT_LE(2, histogram_proto.bucket(0).max());
- EXPECT_EQ(1, histogram_proto.bucket(0).count());
-
- UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager2", 2, 3);
- std::vector<uint8> data2;
- EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data2));
- EXPECT_FALSE(data2.empty());
- ChromeUserMetricsExtension uma_proto2;
- EXPECT_TRUE(uma_proto2.ParseFromArray(
- reinterpret_cast<const char*>(&data2[0]), data2.size()));
- EXPECT_FALSE(data2.empty());
-
- const HistogramEventProto& histogram_proto2 =
- uma_proto2.histogram_event(uma_proto2.histogram_event_size() - 1);
- ASSERT_EQ(1, histogram_proto2.bucket_size());
- EXPECT_LE(0, histogram_proto2.bucket(0).min());
- EXPECT_LE(3, histogram_proto2.bucket(0).max());
- EXPECT_EQ(1, histogram_proto2.bucket(0).count());
-}
-
-} // namespace metrics
« no previous file with comments | « components/metrics/histogram_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698